Review main Merged

40701[BUGFIX] Removing an element from select field must trigger validation

Frank Nägler CR +2 V +2 Easy +3 −0 updated 06/29/15, 08:08

Commit message

This patch ensures that re-validation is triggered in case
an element is removed from a select field.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 9

  1. Frank Nägler uploaded patch set 1 06/27/15, 20:46

  2. Markus Klein updated the commit message in patch set 2 06/28/15, 12:00

  3. Markus Klein voted on patch set 2 CR +1 06/28/15, 12:00

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 06/29/15, 07:54

  5. Anja Leichsenring voted on patch set 2 CR +2 V +2 06/29/15, 07:54

  6. Anja Leichsenring merged patch set 2 06/29/15, 07:54

  7. Mathias Brodala commented on patch set 3 06/29/15, 07:57

    See inline comment.

    FormEngine.js:556

    Post -1: "undefined"
  8. Christian Kuhn commented on patch set 3 06/29/15, 08:01

    FormEngine.js:556 Reply

    foo! ... the patch still worked ... sorry for overreading this typo ...
  9. Frank Nägler commented on patch set 3 06/29/15, 08:08

    FormEngine.js:556 Reply