Review main Merged

40704[TASK] Update Configuration for excludeForPackaging

Benni Mack CR +2 V +2 Easy +1 −1 updated 06/29/15, 09:09

Commit message

Also exclude .swp files.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1

Issues 1

Files 1

Review log 13

  1. Benni Mack uploaded patch set 1 06/28/15, 21:55

  2. Benni Mack updated the commit message in patch set 2 06/28/15, 21:57

  3. Markus Klein commented on patch set 2 CR -1 06/28/15, 21:58

    DefaultConfiguration.php:283

    let me please improve that regex.
  4. Markus Klein commented on patch set 2 06/28/15, 22:03

    DefaultConfiguration.php:283

    IMHO this already covers all files beginning with dot
  5. Markus Klein commented on patch set 2 06/28/15, 22:04

    DefaultConfiguration.php:283 Reply

    We can abandon this patch, except if we want to make the regex perfect by making this a non-capturing group. (?: ... )
  6. Benni Mack uploaded patch set 3 06/29/15, 07:39

  7. Benni Mack uploaded patch set 4 06/29/15, 08:57

  8. Markus Klein voted on patch set 4 CR +1 V +1 06/29/15, 09:06

  9. Benni Mack updated the commit message in patch set 5 06/29/15, 09:06

  10. Anja Leichsenring voted on patch set 4 CR +2 V +2 06/29/15, 09:06

  11. Anja Leichsenring voted on patch set 5 CR +2 V +2 06/29/15, 09:07

  12. Markus Klein voted on patch set 5 CR +1 V +1 06/29/15, 09:09

  13. Markus Klein merged patch set 5 06/29/15, 09:09