Review main Merged

40711[BUGFIX] Only count items in ForViewHelper when ``iteration`` argument is set

Mathias Brodala CR +2 V +2 Easy +25 −5 updated 06/29/15, 12:48

Commit message

When using the ``iteration`` argument, the ``ForViewHelper`` provides
information about the current iteration, including the ``cycle`` and
``total``. Therefore it needs to count all elements.
The problem is, that this happens even if the iteration argument is
not specified leading to performance issues especially when iterating
over a (subset of a) lot of (remote) items.

This patch fixes this by adding a check for the ``iteration`` argument.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • David Greiner +1
  • Verified V +2
    • Anja Leichsenring +2
    • David Greiner +1

Issues 1

Files 2

Review log 5

  1. Mathias Brodala uploaded patch set 1 06/29/15, 07:50

  2. Mathias Brodala uploaded patch set 2 06/29/15, 07:52

  3. David Greiner commented on patch set 2 CR +1 V +1 06/29/15, 11:08

    I have checked whether your unit test fails without your patch. It does. Therefore +1
  4. Anja Leichsenring voted on patch set 2 CR +2 V +2 06/29/15, 12:48

  5. Anja Leichsenring merged patch set 2 06/29/15, 12:48