Review main Merged

40712[FOLLOWUP][BUGFIX] Removing an element from select field must trigger validation

Frank Nägler CR +2 V +2 Easy +1 −1 updated 06/29/15, 08:22

Commit message

Fix typo in typeof comparison.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2
    • Xavier Perseguers +2
    • Anja Leichsenring +1
    • Christian Kuhn +1

Issues 1

Files 1

Review log 13

  1. Frank Nägler uploaded patch set 1 06/29/15, 08:06

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 06/29/15, 08:07

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 06/29/15, 08:07

  4. Mathias Brodala commented on patch set 1 CR -1 06/29/15, 08:09

    [FOLLOWUP][BUGFIX] please
  5. Helmut Hummel commented on patch set 1 06/29/15, 08:13

    @Mathias: can you please adapt such things (especially in the commit message) on your own please instead of voting -1? Thanks a lot!
  6. Anja Leichsenring updated the commit message in patch set 2 06/29/15, 08:17

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 06/29/15, 08:18

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 06/29/15, 08:18

  9. Xavier Perseguers commented on patch set 2 CR +1 06/29/15, 08:18

    obvious
  10. Xavier Perseguers voted on patch set 2 CR +2 V +2 06/29/15, 08:19

  11. Xavier Perseguers merged patch set 2 06/29/15, 08:19

  12. Mathias Brodala commented on patch set 3 06/29/15, 08:20

    @Helmut I' gladly do that but then all existing votes will be removed. What do you think?
  13. Helmut Hummel commented on patch set 3 06/29/15, 08:22

    @Mathias: yes, that is the deal. Voting -1 does not do anything ;)