Review main Merged

40713[BUGFIX] Random PHP warning unlinking valid cache file

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 07/14/15, 21:56

Commit message

Sometimes, although a valid cache path and filename is given to unlink(),
it generates a PHP warning as if the file did not exist.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 12

  1. Xavier Perseguers uploaded patch set 1 06/29/15, 08:09

  2. Christian Kuhn commented on patch set 1 CR +1 V +1 06/29/15, 08:21

    well ... there are race conditions where this may happen, we probably can't suppress this ... thus, i'd vote +1 for this now.
  3. Markus Klein commented on patch set 1 06/29/15, 08:33

    @christian: which race condition do you mean? I can only imagine that 2 requests try to delete the same file nearly at the same time or that the file is actively written, while it is tried to be deleted. That would mean that we (again) lack proper locking for that cache. @Xavier: Do you know which cache is affected?
  4. Xavier Perseguers commented on patch set 1 06/29/15, 08:33

    @Markus: please see ticket
  5. Markus Klein commented on patch set 1 06/29/15, 09:03

    Ok so Fluid cache it is... Is this your local instance, hence no parallel requests?
  6. Xavier Perseguers commented on patch set 1 06/29/15, 09:12

    Yes fully local install. As said, updated the sources (git pull) and then went to http://master.typo3dev.loc/typo3 => bang! (screenshot) 2nd try (page refresh) => login box shown as usual, no more problem
  7. Markus Klein commented on patch set 1 06/29/15, 09:18

    I'm not sure if we should really hide such a warning. I guess we should rather try to find out, how this is possible at all. We're not talking about mystical parallel requests obviously. There must be something wrong in the file handling.
  8. Christian Kuhn voted on patch set 1 CR 0 V 0 06/29/15, 15:31

  9. TYPO3 Bot commented on patch set 1 07/05/15, 20:47

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/203 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/68771137 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/69649840
  10. Christian Kuhn voted on patch set 1 CR +1 V +1 07/14/15, 21:55

  11. Markus Klein voted on patch set 1 CR +2 V +2 07/14/15, 21:56

  12. Markus Klein merged patch set 1 07/14/15, 21:56