Review TYPO3_6-2 Merged

40718[BUGFIX] Only count items in ForViewHelper when ``iteration`` argument is set

Anja Leichsenring CR +2 V +2 Easy +27 −6 updated 06/29/15, 14:10

Commit message

When using the ``iteration`` argument, the ``ForViewHelper`` provides
information about the current iteration, including the ``cycle`` and
``total``. Therefore it needs to count all elements.
The problem is, that this happens even if the iteration argument is
not specified leading to performance issues especially when iterating
over a (subset of a) lot of (remote) items.

This patch fixes this by adding a check for the ``iteration`` argument.

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2

Issues 1

Files 2

Review log 5

  1. Anja Leichsenring uploaded patch set 1 06/29/15, 12:51

  2. Anja Leichsenring voted on patch set 1 CR +2 V +2 06/29/15, 13:04

  3. Anja Leichsenring merged patch set 1 06/29/15, 13:04

  4. Anja Leichsenring commented on patch set 2 06/29/15, 13:38

    stupid me, merged PHP 5.5 syntax. FollowUp on the way.
  5. Nicole Hummel commented on patch set 2 06/29/15, 14:10

    Post -1 -> unresolved ::class in 6.2 branch