Review TYPO3_6-2 Merged

40720[FOLLOWUP][BUGFIX] Only count items in ForViewHelper when ``iteration`` argument is set

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 06/29/15, 15:25

Commit message

Accidently merged a ::class call into 6.2, where PHP 5.3 still needs to work.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +1

Files 1

Review log 12

  1. Anja Leichsenring uploaded patch set 1 06/29/15, 13:41

  2. Anja Leichsenring voted on patch set 1 CR -2 06/29/15, 13:48

  3. Anja Leichsenring uploaded patch set 2 06/29/15, 14:20

  4. Anja Leichsenring voted on patch set 2 CR 0 06/29/15, 14:21

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 06/29/15, 14:23

  6. Nicole Hummel commented on patch set 2 V -1 06/29/15, 15:03

    ForViewHelperTest.php:406

    Undefined constant 'ArrayObject'
  7. Anja Leichsenring commented on patch set 2 06/29/15, 15:08

    this is the test run from patchset 1.
  8. Anja Leichsenring updated the commit message in patch set 3 06/29/15, 15:13

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 06/29/15, 15:18

  10. Nicole Hummel commented on patch set 3 CR +1 V +1 06/29/15, 15:19

    Ran unit tests locally with 5.3 and 5.5
  11. Christian Kuhn voted on patch set 3 CR +2 V +2 06/29/15, 15:25

  12. Christian Kuhn merged patch set 3 06/29/15, 15:25