Review main Merged

40724[BUGFIX] Namespace prefix t3 for id on file is not defined

Xavier Perseguers CR +2 V +2 Easy +40 −10 updated 06/30/15, 07:42

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1

Issues 1

Files 2

Review log 12

  1. Xavier Perseguers uploaded patch set 1 06/29/15, 15:12

  2. Xavier Perseguers commented on patch set 1 06/29/15, 15:15

    @lolli: something to be added to the travis check?
  3. Christian Kuhn commented on patch set 1 06/29/15, 15:17

    well ... maybe typo3/sysext/core/Build/Scripts/xlfcheck.sh could be changed to check for existance of xmlns attribute.
  4. Christian Kuhn commented on patch set 1 CR -1 06/29/15, 15:24

    xavier still working on this.
  5. Xavier Perseguers uploaded patch set 2 06/29/15, 15:40

  6. Xavier Perseguers commented on patch set 2 06/29/15, 15:41

    @markus: could you please check/fix the travis check? cannot run it properly because of other versions of sed/grep. Thx!
  7. Markus Klein commented on patch set 2 06/29/15, 15:47

    I'll check the modifies M for sed and -LP for grep I've no Mac to test, but will look stuff up
  8. Markus Klein uploaded patch set 3 06/29/15, 23:08

  9. Markus Klein uploaded patch set 4 06/29/15, 23:11

  10. Markus Klein voted on patch set 4 CR +1 V +1 06/29/15, 23:12

  11. Andreas Kienast voted on patch set 4 CR +2 V +2 06/30/15, 07:42

  12. Andreas Kienast merged patch set 4 06/30/15, 07:42