40736[TASK] Remove unused icons in Table and Form wizard controller
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2
- Christian Kuhn +2
- Benni Mack +1
Issues 1
Files 13
- typo3/gfx/garbage.gifdeletedbinary
- typo3/gfx/information.pngdeletedbinary
- typo3/gfx/pil2down.gifdeletedbinary
- typo3/gfx/pil2right.gifdeletedbinary
- typo3/gfx/pil2up.gifdeletedbinary
- typo3/gfx/saveandclosedok.gifdeletedbinary
- typo3/gfx/savedok.gifdeletedbinary
- typo3/gfx/turn_down.gifdeletedbinary
- typo3/gfx/turn_left.gifdeletedbinary
- typo3/gfx/turn_right.gifdeletedbinary
- typo3/gfx/turn_up.gifdeletedbinary
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+2 −2
- typo3/sysext/compatibility6/Classes/Controller/Wizard/FormsController.php+11 −12
Review log 14
-
Wouter Wolters uploaded patch set 1 06/29/15, 22:17
-
Markus Klein updated the commit message in patch set 2 06/29/15, 22:20
-
Markus Klein commented on patch set 2 CR +1 V +1 06/29/15, 22:26
I expect some extensions to break, which may still use the gfx/save*.gif icons. -
Benni Mack commented on patch set 2 CR -1 06/29/15, 22:53
I think we should replace turn_down and turn_up with button and sprite icons, so we can remove the files completely. -
Wouter Wolters commented on patch set 2 06/30/15, 06:35
Feel free to push an update, the icons will be moved with the compatibility6 extension, so I don't really see the need to put more work in this. -
Benni Mack commented on patch set 2 06/30/15, 07:40
well, at the end of the day, we should be able to deprecate IconUtility::skinImg() - (once gfx/ is gone) -
TYPO3 Bot commented on patch set 2 07/05/15, 21:10
Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/205 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/68887953 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/69651592 -
Benni Mack uploaded patch set 3 07/07/15, 06:54
-
Wouter Wolters commented on patch set 3 CR +1 07/07/15, 06:57
Thanks Benni :-) -
Benni Mack uploaded patch set 4 07/07/15, 07:01
-
Benni Mack voted on patch set 4 CR +1 V +1 07/07/15, 07:01
-
Christian Kuhn commented on patch set 4 07/07/15, 07:18
on it ... -
Christian Kuhn voted on patch set 4 CR +2 V +2 07/07/15, 07:37
-
Christian Kuhn merged patch set 4 07/07/15, 07:39