40740[TASK] Rewrite "Show hidden content elements" to JavaScript
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Christian Kuhn +1
-
Verified V +2
- Markus Klein +2
- Christian Kuhn +1
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+12 −11
- typo3/sysext/backend/Classes/View/PageLayoutView.php2+7 −5
- typo3/sysext/backend/Resources/Public/JavaScript/PageActions.js3+51 −10
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_element_spinner.less+7 −0
- typo3/sysext/t3skin/Resources/Public/Css/visual/t3skin.css+5 −0
Review log 24
-
Andreas Kienast uploaded patch set 1 06/30/15, 06:25
-
Andreas Kienast commented on patch set 1 V -1 06/30/15, 06:29
Nasty side-effect: toggling the checkbox in "Languages" and in "Columns" afterwards lets the Page module load the "Languages" view again. -
Andreas Kienast uploaded patch set 2 06/30/15, 06:37
-
Andreas Kienast uploaded patch set 3 06/30/15, 07:37
-
Christian Kuhn commented on patch set 3 CR -1 06/30/15, 08:30
love the patch already. very nice. however, the 'quick edit show hidden' is broken with applied patch, i think this needs to be fixed somehow (maybe fall back to reload in quick edit if that is easier?) -
Andreas Kienast uploaded patch set 4 06/30/15, 15:09
-
Andreas Kienast uploaded patch set 5 06/30/15, 15:13
-
Andreas Kienast uploaded patch set 6 06/30/15, 15:15
-
Andreas Kienast commented on patch set 6 06/30/15, 15:15
Had to revert to PS 4, as my intended change didn't work properly -
Markus Klein commented on patch set 6 06/30/15, 16:40
PageLayoutView.php:511no need to cast here, ! makes that automaticallyPageLayoutView.php:513put the style into the string of $displayNone? -
Markus Klein updated the commit message in patch set 7 06/30/15, 17:04
-
Christian Kuhn uploaded patch set 8 06/30/15, 22:23
-
Christian Kuhn commented on patch set 8 06/30/15, 22:27
the behavior of the "show hidden" checkbox in quick edit mode is still somehow strange: the drop-down in the docheader now always contains the hidden records no matter what the checkbox is set to. this was different before. also, the checkbox manipulates the "Content elements on this page" display below the form ... all in all, the "show hidden" checkbox is no really useful in this context, and i'm thinking about dropping it altogether and always showing all elements in this context ... but i'm a bit unsure ... what do you think? -
Christian Kuhn commented on patch set 8 06/30/15, 22:29
somehow the current 'quick edit' is more or less doomed anyway and should receive a bigger overhaul. the functionality itself is cool, but i could image a much cooler interface, too ... maybe we also could live with the now 'even more weird' behavior for now and talk to ux felix/benji on the one or the other quick-win patch for this module part later. in this case, i'd suggest to pick the patch as is. -
Andreas Kienast uploaded patch set 9 07/01/15, 07:41
-
Andreas Kienast commented on patch set 8 07/01/15, 07:42
I forgot to revert all other changes in `renderQuickEdit`. I agree to overhaul the complete section, but opt to keep it as it is for the time being. -
Markus Klein commented on patch set 9 07/01/15, 10:05
PageActions.js:31that should happen in the ready() function not here, this might not work -
Andreas Kienast uploaded patch set 10 07/01/15, 14:36
-
Markus Klein commented on patch set 10 07/06/15, 09:52
PageActions.js:209this fucntion is not neededPageActions.js:210do we need to have that as public object? -
Andreas Kienast uploaded patch set 11 07/06/15, 10:35
-
Markus Klein voted on patch set 11 CR +1 07/06/15, 12:18
-
Christian Kuhn commented on patch set 11 CR +1 V +1 07/06/15, 18:12
love it. get it in :) -
Markus Klein voted on patch set 11 V +2 CR +2 07/06/15, 18:49
-
Markus Klein merged patch set 11 07/06/15, 18:49