Review main Merged

40749[BUGFIX] Fix SQL error in IndexSearchRepository

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 06/30/15, 10:05

Commit message

Add a missing "AND" concatenation to fix a SQL error.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • David Greiner +1
    • Tymoteusz Motylewski +1
    • Mathias Brodala +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 12

  1. Andreas Kienast uploaded patch set 1 06/30/15, 08:12

  2. David Greiner voted on patch set 1 CR +1 06/30/15, 08:15

  3. Markus Klein voted on patch set 1 CR +1 V +1 06/30/15, 08:19

  4. Mathias Brodala voted on patch set 1 CR +1 06/30/15, 08:22

  5. Wouter Wolters voted on patch set 1 V +1 CR +1 06/30/15, 08:23

  6. Tymoteusz Motylewski commented on patch set 1 CR +1 06/30/15, 08:33

    have also checked other places like SearchFormController and FulltextIndexHook, and it looks ok there
  7. Wouter Wolters voted on patch set 1 V +2 CR +2 06/30/15, 08:43

  8. Wouter Wolters merged patch set 1 06/30/15, 08:44

  9. Wouter Wolters commented on patch set 2 06/30/15, 08:44

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 93283d693260f567d4fb878f13cb21a83ec0b8e9
  10. Christian Kuhn commented on patch set 2 06/30/15, 09:21

    see my comment on the 6.2 version https://review.typo3.org/#/c/40752/1 - do we need a follow-up here to have a whitespace after AND?
  11. Markus Klein commented on patch set 2 06/30/15, 10:02

    I'll get a coffee first... I just don't get it... how did my tests work and how did I overlook that?
  12. Markus Klein commented on patch set 2 06/30/15, 10:05