Review main Merged

40764[BUGFIX] Locallang file is not an XLIFF file in ext:extensionmanager

Wouter Wolters CR +2 V +2 Normal +71 −34 updated 06/30/15, 21:54

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +2
    • Stephan Großberndt +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 2

Review log 12

  1. Wouter Wolters uploaded patch set 1 06/30/15, 10:00

  2. Stephan Großberndt voted on patch set 1 CR +1 06/30/15, 14:31

  3. Frederic Gaus commented on patch set 1 06/30/15, 15:06

    Renaming the file is not enough iirc. I think we have to convert it into an xliff file - e.g. with http://typo3.org/extensions/repository/view/extdeveval
  4. Wouter Wolters uploaded patch set 2 06/30/15, 15:56

  5. Wouter Wolters uploaded patch set 3 06/30/15, 15:59

  6. Stephan Großberndt commented on patch set 3 CR -1 06/30/15, 16:05

    locallang_db.xlf:6

    all xml:space="preserve" should be removed
  7. Wouter Wolters uploaded patch set 4 06/30/15, 16:06

  8. Stephan Großberndt voted on patch set 4 CR +1 06/30/15, 16:07

  9. Markus Klein voted on patch set 4 CR +1 V +1 06/30/15, 16:53

  10. Andreas Kienast voted on patch set 4 CR +2 06/30/15, 18:44

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 06/30/15, 21:54

  12. Christian Kuhn merged patch set 4 06/30/15, 21:54