Review main Merged

40804[SECURITY] Prevent edit of file metadata of files with no access

Helmut Hummel CR +2 V +2 Normal +208 −0 updated 07/01/15, 14:09

Commit message

By forging edit URLs it was possible to edit
meta data records of files which were not
within a user mount.

Implement several hooks to check access to the file
and only grant access to a meta data record if the
user has access to the file.

Review

  • Code review CR +2
    • Benni Mack +2
    • Helmut Hummel +1
  • Verified V +2
    • Benni Mack +2
    • Helmut Hummel +1

Issues 1

Files 4

Review log 4

  1. Helmut Hummel uploaded patch set 1 07/01/15, 14:07

  2. Benni Mack voted on patch set 1 CR +2 V +2 07/01/15, 14:09

  3. Helmut Hummel voted on patch set 1 CR +1 V +1 07/01/15, 14:09

  4. Benni Mack merged patch set 3 07/01/15, 14:09