Review main Merged

40830[BUGFIX] keep options array for TableGarbageCollectionTask

Daniel Neugebauer CR +2 V +2 Easy +14 −10 updated 07/06/15, 20:58

Commit message

scheduler now keeps an options sub-array if it has been populated
before ext_localconf.php runs.

User can define additional options for TableGarbageCollectionTask as
per extension documentation, i.e. tables can be added from user
configuration files such as AdditionalConfiguration.php.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 5

  1. Daniel Neugebauer uploaded patch set 1 07/01/15, 17:49

  2. Christian Kuhn uploaded patch set 2 07/06/15, 20:04

  3. Christian Kuhn commented on patch set 2 CR +1 V +1 07/06/15, 20:07

    thx. good catch. i just renamed the temp variable and added an unset() since this code still runs in global scope and we don't want to pollute this.
  4. Wouter Wolters voted on patch set 2 V +2 CR +2 07/06/15, 20:58

  5. Wouter Wolters merged patch set 2 07/06/15, 20:58