Review main Merged

40843[FEATURE] Add base date for DateTimeViewHelper

Markus Klein CR +2 V +2 Normal +64 −9 updated 08/26/15, 21:41

Commit message

This allows to use the full set of relative date formats
on a given base time:
http://www.php.net/manual/en/datetime.formats.relative.php

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 13

  1. Markus Klein uploaded patch set 1 07/01/15, 21:18

  2. Markus Klein commented on patch set 1 07/01/15, 21:35

    DateViewHelper.php:87

    we could even drop that "int" limitation... see below

    DateViewHelper.php:129

    ... by adding one line here: $base = strtotime((MathUtility::canBeInterpretedAsInteger($date) ? '@' : '') . $base);
  3. Markus Klein uploaded patch set 2 07/01/15, 22:03

  4. Markus Klein uploaded patch set 3 07/01/15, 22:04

  5. Mathias Brodala commented on patch set 3 07/02/15, 08:35

    DateViewHelper.php:101

    Why doesn't it default to "now" as advertised?
  6. Markus Klein commented on patch set 3 07/02/15, 08:52

    DateViewHelper.php:101 Reply

    lets change "now" to "current time"
  7. Anja Leichsenring commented on patch set 3 07/09/15, 20:14

    I like it, lets bring it in.
  8. Markus Klein uploaded patch set 4 07/09/15, 21:02

  9. Christian Kuhn commented on patch set 4 CR +1 V +1 07/09/15, 21:05

    i like.
  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 07/09/15, 21:06

  11. Anja Leichsenring voted on patch set 4 CR +2 V +2 07/09/15, 21:12

  12. Anja Leichsenring merged patch set 4 07/09/15, 21:12

  13. Markus Klein commented on patch set 5 08/26/15, 21:41

    DateViewHelper.php:137

    regression here. this must be $base of course. https://forge.typo3.org/issues/69335