Review main Merged

40922[BUGFIX] Split check for adding adminPanelHeaderData

David Greiner CR +2 V +2 Easy +7 −7 updated 07/17/15, 09:11

Commit message

The check is split into "is the panel enabled" and "should it be
visible", as additional adminPanelHeaderData should also be rendered
if the admin panel is enabled but not visible.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 1

Review log 9

  1. David Greiner uploaded patch set 1 07/05/15, 16:21

  2. Daniel Goerz commented on patch set 1 07/05/15, 18:32

    I am not sure if this is the correct approach. If I am not mistaken every enable setting in a user TSConfig of a backend user group overrides the hide=1 configuration now.
    typo: visible
  3. David Greiner commented on patch set 1 07/06/15, 07:27

    Yes, you are right. I have to rework this. If hide=1 all the other options shouldn't override this setting.
  4. David Greiner uploaded patch set 2 07/08/15, 08:46

  5. David Greiner uploaded patch set 3 07/08/15, 08:48

  6. Daniel Goerz voted on patch set 3 V +1 CR +1 07/12/15, 10:21

  7. Andreas Wolf uploaded patch set 4 07/17/15, 09:10

  8. Andreas Wolf commented on patch set 4 CR +2 V +2 07/17/15, 09:10

    Just updated the commit message to conform to our standard.
  9. Andreas Wolf merged patch set 4 07/17/15, 09:11