Review main Merged

40926[BUGFIX] Avoid non-blocking flock() calls Windows

Markus Klein CR +2 V +2 Easy +8 −1 updated 07/06/15, 21:27

Commit message

Don't advertise the non-blocking capability of the
FileLockStrategy on Windows systems with PHP versions
below 5.5.23 or 5.6.7.
The non-blocking feature of flock() for Windows was
introduced with the aforementioned versions.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 11

  1. Markus Klein uploaded patch set 1 07/06/15, 09:50

  2. Helmut Hummel voted on patch set 1 CR +1 07/06/15, 12:22

  3. Markus Klein updated the commit message in patch set 2 07/06/15, 15:47

  4. Frederic Gaus voted on patch set 2 CR +1 07/06/15, 16:01

  5. Christian Kuhn commented on patch set 2 07/06/15, 17:25

    FileLockStrategy.php:161

    i don't like the < 7.0.0 ... this means 7.0.1 or above will not be detected as valid, so this area will need maintenance in the future?
  6. Markus Klein commented on patch set 2 CR -1 07/06/15, 17:34

    Thanks Christian!

    FileLockStrategy.php:161 Reply

    Args... of course that was not intended. needs to be changed!
  7. Christian Kuhn uploaded patch set 3 07/06/15, 18:00

  8. Christian Kuhn commented on patch set 3 CR +1 V +1 07/06/15, 18:01

    just removed the 7.0.0 constrain. looks good to me now.
  9. Wouter Wolters voted on patch set 3 CR +1 07/06/15, 19:44

  10. Wouter Wolters voted on patch set 3 V +2 CR +2 07/06/15, 21:27

  11. Wouter Wolters merged patch set 3 07/06/15, 21:27