Review main Merged

40936[BUGFIX] jquery loaded twice if loadJQuery="true" is set via fluid

Alexander Kontos CR +2 V +2 Easy +2 −2 updated 11/16/15, 11:59

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Sommer +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Sommer +1

Issues 1

Files 2

Review log 9

  1. Alexander Kontos uploaded patch set 1 07/06/15, 19:58

  2. Wouter Wolters commented on patch set 1 V -1 CR -1 07/06/15, 21:19

    Wrong approach. Alexander solved his problem in a different way now but this should be tackled somehow. No idea yet how to solve it.
  3. Christian Kuhn commented on patch set 1 07/06/15, 21:41

    As far as i understand, jquery is always loaded in backend context. Couldn't we just deprecate the loadjquery property in container vh, hinting that setting this to true will likely break the module?
  4. Benni Mack uploaded patch set 2 11/12/15, 21:49

  5. Georg Ringer voted on patch set 2 CR +1 V +1 11/14/15, 20:09

  6. Markus Sommer voted on patch set 2 CR +1 V +1 11/15/15, 19:46

  7. Benni Mack voted on patch set 2 CR +2 V +2 11/16/15, 06:12

  8. Gerrit merged patch set 2 11/16/15, 06:12

  9. Andreas Kienast commented on patch set 3 11/16/15, 11:59

    Post -1, breaks the EM as we use non-amd modules here.