Review main Merged

40946[BUGFIX] Use correct active CSS class in RTE toolbars

Andreas Kienast CR +2 V +2 Easy +5 −5 updated 07/07/15, 14:29

Commit message

The button class "active" is used now and replaces the broken
class "btn-active".

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 7

  1. Andreas Kienast uploaded patch set 1 07/07/15, 08:06

  2. Christian Kuhn commented on patch set 1 07/07/15, 13:53

    htmlarea.css:71

    there is a dupe of this file in t3skin ... probably needs to be resolved there as well.
  3. Christian Kuhn uploaded patch set 2 07/07/15, 14:01

  4. Andreas Kienast commented on patch set 2 07/07/15, 14:02

    Good catch, thx
  5. Christian Kuhn commented on patch set 2 CR +1 V +1 07/07/15, 14:03

    fine with me ... btw - frank and me think we should resolve this duplicate .css stuff mess by moving rte to .less ... i can take care, but if anyone wants to step in - please talk to me.
  6. Anja Leichsenring voted on patch set 2 CR +2 V +2 07/07/15, 14:29

  7. Anja Leichsenring merged patch set 2 07/07/15, 14:29