Review main Merged Breaking

40948[!!!][TASK] Restructure lowlevel commands and documentation

Benni Mack CR +2 V +2 Hard +309 −208 updated 07/09/15, 06:26

Commit message

The HOWTO cleanup TYPO3 installations document is moved to a README.md
file. The shell scripts for checking and cleaning tasks have been
removed and have been documented in the README.md.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1

Issues 1

Files 6

Review log 13

  1. Benni Mack uploaded patch set 1 07/07/15, 10:45

  2. Wouter Wolters commented on patch set 1 07/07/15, 10:56

    README.md:223

    PHP4 constructor, can we update this now? Would be great.
  3. Andreas Kienast commented on patch set 1 07/07/15, 10:57

    Why don't we have ReST document?
  4. Benni Mack commented on patch set 1 07/07/15, 12:15

    on the base level there are README.md and INSTALL.md - so I took the liberty to do it the same way.
  5. Benni Mack uploaded patch set 2 07/07/15, 12:17

  6. Frans Saris voted on patch set 2 CR +1 07/07/15, 12:20

  7. Wouter Wolters commented on patch set 2 07/07/15, 12:23

    README.md:217

    we should replace tx_lowlevel_cleaner_core to \TYPO3\CMS\Lowlevel\CleanerCommand
  8. Wouter Wolters uploaded patch set 3 07/07/15, 12:25

  9. Wouter Wolters voted on patch set 3 CR +1 07/07/15, 12:25

  10. Andreas Kienast voted on patch set 3 CR +1 V +1 07/07/15, 12:42

  11. Christian Kuhn commented on patch set 3 CR +2 V +2 07/07/15, 12:52

    lol. nice. thx :)
  12. Christian Kuhn merged patch set 3 07/07/15, 12:52

  13. Xavier Perseguers commented on patch set 4 07/09/15, 06:26

    Post -1 for using README.md. Markdown is not the official documentation format for Core extensions. It is only *partially* supported for extension authors being not aware of the official formatting language: reST. It should be changed to README.rst, just as other (simple) extension manuals.