Review main Merged

40977[TASK] Remove class alias map in form

Helmut Hummel CR +2 V +2 Normal +139 −64 updated 07/08/15, 05:19

Commit message

The alias map in form system extension is a workaround
to enable case insensitive class loading for specific
form classes.

Instead of misusing this technology, introduce an object factory
class which does the mapping within the form extension where it belongs
without affecting the complete system.

By doing so and removing the last alias map (besides the one in compatibility6)
we now have to improve our code for dynamic alias addition since the default
loader is not the alias loader any more but the regular composer class loader.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 23

Show 3 more files

Review log 9

  1. Helmut Hummel uploaded patch set 1 07/07/15, 18:14

  2. Helmut Hummel uploaded patch set 2 07/07/15, 18:58

  3. Wouter Wolters commented on patch set 2 07/07/15, 21:15

    ClassLoadingInformation.php:165

    missing @param here

    ClassLoadingInformation.php:173

    TRUE, TRUE

    ObjectFactory.php:7

    we use a different license header now
  4. Helmut Hummel commented on patch set 2 07/07/15, 22:01

    ClassLoadingInformation.php:165 Reply

    Done

    ClassLoadingInformation.php:173 Reply

    Done

    ObjectFactory.php:7 Reply

    Done
  5. Helmut Hummel uploaded patch set 3 07/07/15, 22:01

  6. Wouter Wolters voted on patch set 3 V +1 CR +1 07/07/15, 22:16

  7. Christian Kuhn voted on patch set 3 CR +2 V +2 07/08/15, 05:18

  8. Christian Kuhn commented on patch set 3 07/08/15, 05:19

    clever :)
  9. Christian Kuhn merged patch set 3 07/08/15, 05:19