Review main Merged

40987[TASK] Add check for max_input_vars setting in install tool

Frank Nägler CR +2 V +2 Easy +38 −0 updated 07/09/15, 13:01

Commit message

This patch add a check for max_input_vars setting.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frederic Gaus +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Frederic Gaus +1

Issues 2

Files 1

Review log 22

  1. Frank Nägler uploaded patch set 1 07/08/15, 09:50

  2. Andreas Kienast commented on patch set 1 07/08/15, 09:58

    Check.php:595

    Isn't the wording "Install Tool"?
  3. Frank Nägler commented on patch set 1 07/08/15, 10:09

    Check.php:595 Reply

    I copy the message from another check.
  4. Christian Kuhn commented on patch set 1 07/08/15, 10:18

    Check.php:587

    is 0 / false / empty value allowed for max_input_vars and then handled in php as "no limit"? if so (could not find anything about that, so it probably needs a test), this code needs adaption.
  5. Frank Nägler commented on patch set 1 07/08/15, 10:29

    Check.php:587 Reply

    good point, but max_input_vars is defined as integer, and setting this value to "no limit" make no sense. The docu can be find here: http://php.net/manual/en/info.configuration.php#ini.max-input-vars As far as I can tell, there is no way to make max_input_vars unlimited. this directive has been added recently as a security measure.
  6. Stephan Großberndt commented on patch set 1 07/08/15, 10:33

    Check.php:587 Reply

    What happens if it is set to 0 or -1?
  7. Frank Nägler commented on patch set 1 07/08/15, 11:04

    Check.php:587 Reply

    value 0 result in: PHP Warning: Unknown: Input variables exceeded 0. To increase the limit change max_input_vars in php.ini. in Unknown on line 0 value -1 result in the default value, in the most cases, this 1000
  8. Christian Kuhn updated the commit message in patch set 2 07/08/15, 18:52

  9. Christian Kuhn commented on patch set 2 CR +1 V +1 07/08/15, 18:52

    works as advertised.
  10. Wouter Wolters commented on patch set 2 CR -1 07/08/15, 19:17

    Check.php:599

    elseif
  11. Christian Kuhn uploaded patch set 3 07/08/15, 20:03

  12. Christian Kuhn voted on patch set 3 CR +1 V +1 07/08/15, 20:03

  13. Wouter Wolters voted on patch set 3 CR +1 07/08/15, 22:00

  14. Georg Ringer commented on patch set 3 CR -1 07/09/15, 04:43

    Check.php:593

    htmlspecialchars() here and below
  15. Frank Nägler commented on patch set 3 07/09/15, 07:07

    Check.php:593 Reply

    Hi Georg, please remove your -1 vote, there is no reason for hsc in this place. The text is not send to the browser here, this is done later in the view which take care of hsc.
  16. Frederic Gaus voted on patch set 3 CR +1 V +1 07/09/15, 08:21

  17. Frederic Gaus commented on patch set 3 07/09/15, 08:24

    Should this be backported for 6.2?
  18. Frank Nägler commented on patch set 3 07/09/15, 08:27

    Lolli (and I) decided to not backport this, because the install tool would show a warning with a minor update, which could confuse someone.
  19. Frederic Gaus commented on patch set 3 07/09/15, 08:34

    Yes, I'm fine with this decision. But it might also confuse a (smaller) group of users because the didnt get a warning and reach the limit of the configuration. ;)
  20. Georg Ringer voted on patch set 3 CR 0 07/09/15, 12:53

  21. Christian Kuhn voted on patch set 3 CR +2 V +2 07/09/15, 13:01

  22. Christian Kuhn merged patch set 3 07/09/15, 13:01