40987[TASK] Add check for max_input_vars setting in install tool
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frederic Gaus +1
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Frederic Gaus +1
Issues 2
Files 1
Review log 22
-
Frank Nägler uploaded patch set 1 07/08/15, 09:50
-
Andreas Kienast commented on patch set 1 07/08/15, 09:58
-
Frank Nägler commented on patch set 1 07/08/15, 10:09
Check.php:595ReplyI copy the message from another check. -
Christian Kuhn commented on patch set 1 07/08/15, 10:18
Check.php:587is 0 / false / empty value allowed for max_input_vars and then handled in php as "no limit"? if so (could not find anything about that, so it probably needs a test), this code needs adaption. -
Frank Nägler commented on patch set 1 07/08/15, 10:29
Check.php:587Replygood point, but max_input_vars is defined as integer, and setting this value to "no limit" make no sense. The docu can be find here: http://php.net/manual/en/info.configuration.php#ini.max-input-vars As far as I can tell, there is no way to make max_input_vars unlimited. this directive has been added recently as a security measure. -
Stephan Großberndt commented on patch set 1 07/08/15, 10:33
Check.php:587ReplyWhat happens if it is set to 0 or -1? -
Frank Nägler commented on patch set 1 07/08/15, 11:04
Check.php:587Replyvalue 0 result in: PHP Warning: Unknown: Input variables exceeded 0. To increase the limit change max_input_vars in php.ini. in Unknown on line 0 value -1 result in the default value, in the most cases, this 1000 -
Christian Kuhn updated the commit message in patch set 2 07/08/15, 18:52
-
Christian Kuhn commented on patch set 2 CR +1 V +1 07/08/15, 18:52
works as advertised. -
Wouter Wolters commented on patch set 2 CR -1 07/08/15, 19:17
Check.php:599elseif -
Christian Kuhn uploaded patch set 3 07/08/15, 20:03
-
Christian Kuhn voted on patch set 3 CR +1 V +1 07/08/15, 20:03
-
Wouter Wolters voted on patch set 3 CR +1 07/08/15, 22:00
-
Georg Ringer commented on patch set 3 CR -1 07/09/15, 04:43
Check.php:593htmlspecialchars() here and below -
Frank Nägler commented on patch set 3 07/09/15, 07:07
Check.php:593ReplyHi Georg, please remove your -1 vote, there is no reason for hsc in this place. The text is not send to the browser here, this is done later in the view which take care of hsc. -
Frederic Gaus voted on patch set 3 CR +1 V +1 07/09/15, 08:21
-
Frederic Gaus commented on patch set 3 07/09/15, 08:24
Should this be backported for 6.2? -
Frank Nägler commented on patch set 3 07/09/15, 08:27
Lolli (and I) decided to not backport this, because the install tool would show a warning with a minor update, which could confuse someone. -
Frederic Gaus commented on patch set 3 07/09/15, 08:34
Yes, I'm fine with this decision. But it might also confuse a (smaller) group of users because the didnt get a warning and reach the limit of the configuration. ;) -
Georg Ringer voted on patch set 3 CR 0 07/09/15, 12:53
-
Christian Kuhn voted on patch set 3 CR +2 V +2 07/09/15, 13:01
-
Christian Kuhn merged patch set 3 07/09/15, 13:01
Check.php:595