Review main Merged

41004[TASK] Entry script handling cleanup

Christian Kuhn CR +2 V +2 Hard +46 −228 updated 07/08/15, 21:59

Commit message

The patch drops handling and definition of the constants
TYPO3_MOD_PATH and PATH_typo3_mod that were used for script
path resolution and some resource calculations.
This is an important step for further routing scripts
within the core and module bootstrap.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1

Issues 1

Files 18

Review log 12

  1. Christian Kuhn uploaded patch set 1 07/08/15, 17:12

  2. Christian Kuhn commented on patch set 1 07/08/15, 17:19

    FormEngineUtility.php:230

    constant can be just removed if no longer defined, was empty string anyway ... another patch in this area will follow.

    conf.php:2

    this file and the two entry scripts must be removed if the module path is no longer defined ... see breaking .rst for this.

    conf.php:2

    this one is probably harmless and only a leftover.

    conf.php:3

    this file is unused since 4.5. should be safe.

    locallang_csh_em.xlf:308

    unused since old-old em ... there are probably more, but i did not want to pollute too much with this patch.

    class.tx_openid_return.php:21

    i'm not 100% sure about this change ... could anyone please check if the login with openid still works?

    index.php:14

    this seems to work, can be checked by editing a BE user and calling the openid wizard.
  3. Wouter Wolters commented on patch set 1 07/08/15, 17:21

    Breaking-67987-RemovedEntryScriptHandling.rst:23

    scripts

    Breaking-67987-RemovedEntryScriptHandling.rst:32

    you can also define this information in an array to not use conf.php, maybe mention this too here
  4. Christian Kuhn commented on patch set 1 CR -1 07/08/15, 19:26

    markus detected a problem with openid ... he is working on it.
  5. Markus Klein uploaded patch set 2 07/08/15, 20:27

  6. Markus Klein commented on patch set 2 CR +1 V +1 07/08/15, 20:29

    AbstractUserAuthentication.php:1293

    we need this change, in order to be able to create a return-url for openid
  7. Markus Klein commented on patch set 2 07/08/15, 20:40

    OpenidService.php:421

    we don't even need that here
  8. Markus Klein uploaded patch set 3 07/08/15, 20:43

  9. Markus Klein voted on patch set 3 CR +1 V +1 07/08/15, 20:43

  10. Benni Mack commented on patch set 3 CR +2 V +2 07/08/15, 21:32

    very cool! thx!
  11. Benni Mack merged patch set 3 07/08/15, 21:32

  12. Helmut Hummel commented on patch set 3 07/08/15, 21:59

    Great change! Thanks! Post +1

    SystemEnvironmentBuilder.php:436

    I wanted to get rid of this code for sooo long already! Thanks!