41004[TASK] Entry script handling cleanup
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Markus Klein +1
-
Verified V +2
- Benni Mack +2
- Markus Klein +1
Issues 1
Files 18
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+0 −1
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php1+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+0 −1
- typo3/sysext/cms/layout/conf.php1deleted+0 −8
- typo3/sysext/cms/layout/db_layout.phpdeleted+0 −43
- typo3/sysext/cms/layout/db_new_content_el.phpdeleted+0 −44
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php1+1 −2
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php1+4 −61
- typo3/sysext/core/Documentation/Changelog/7.1/Deprecation-64922-DeprecatedEntryPoints.rst+1 −7
- typo3/sysext/core/Documentation/Changelog/master/Breaking-67987-RemovedEntryScriptHandling.rst2new+35 −0
- typo3/sysext/impexp/app/conf.php1+0 −1
- typo3/sysext/indexed_search/cli/conf.php1deleted+0 −5
- typo3/sysext/lang/locallang_csh_em.xlf1+0 −15
- typo3/sysext/openid/Classes/OpenidService.php1+1 −1
- typo3/sysext/openid/wizard/index.php1+0 −2
- typo3/sysext/openid/class.tx_openid_return.php1deleted+0 −33
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+2 −2
- typo3/sysext/recordlist/mod1/index.php+1 −1
Review log 12
-
Christian Kuhn uploaded patch set 1 07/08/15, 17:12
-
Christian Kuhn commented on patch set 1 07/08/15, 17:19
conf.php:2this file and the two entry scripts must be removed if the module path is no longer defined ... see breaking .rst for this.conf.php:2this one is probably harmless and only a leftover.conf.php:3this file is unused since 4.5. should be safe.locallang_csh_em.xlf:308unused since old-old em ... there are probably more, but i did not want to pollute too much with this patch.class.tx_openid_return.php:21i'm not 100% sure about this change ... could anyone please check if the login with openid still works?index.php:14this seems to work, can be checked by editing a BE user and calling the openid wizard. -
Wouter Wolters commented on patch set 1 07/08/15, 17:21
Breaking-67987-RemovedEntryScriptHandling.rst:23scriptsBreaking-67987-RemovedEntryScriptHandling.rst:32you can also define this information in an array to not use conf.php, maybe mention this too here -
Christian Kuhn commented on patch set 1 CR -1 07/08/15, 19:26
markus detected a problem with openid ... he is working on it. -
Markus Klein uploaded patch set 2 07/08/15, 20:27
-
Markus Klein commented on patch set 2 CR +1 V +1 07/08/15, 20:29
AbstractUserAuthentication.php:1293we need this change, in order to be able to create a return-url for openid -
Markus Klein commented on patch set 2 07/08/15, 20:40
OpenidService.php:421we don't even need that here -
Markus Klein uploaded patch set 3 07/08/15, 20:43
-
Markus Klein voted on patch set 3 CR +1 V +1 07/08/15, 20:43
-
Benni Mack commented on patch set 3 CR +2 V +2 07/08/15, 21:32
very cool! thx! -
Benni Mack merged patch set 3 07/08/15, 21:32
-
Helmut Hummel commented on patch set 3 07/08/15, 21:59
Great change! Thanks! Post +1SystemEnvironmentBuilder.php:436I wanted to get rid of this code for sooo long already! Thanks!
FormEngineUtility.php:230