Review main Merged

41024[TASK] Remove extension class for ElementBrowserFolderTreeView

Thomas Schlumberger CR +2 V +2 Normal +16 −69 updated 07/09/15, 10:28

Commit message

EXT:recordlist ships with an extended ElementBrowserFolderTreeView
which is a subclass of the regular ElementBrowserFolderTreeView from
EXT:backend. The subclass can be easily merged into the parent class
as the logic is non-breaking for the areas which use the parent class.

The patch removes the child class (4th level inheritance!) into the parent
class and changes all occurences in the core to the parent class.

A class alias map is added for the old class into EXT:compatibility6.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1

Issues 1

Files 5

Review log 6

  1. Thomas Schlumberger uploaded patch set 1 07/09/15, 09:46

  2. Wouter Wolters commented on patch set 1 07/09/15, 09:48

    ElementBrowserFolderTreeView.php:70

    === use strict comparison for both checks
  3. Thomas Schlumberger uploaded patch set 2 07/09/15, 10:21

  4. Benni Mack voted on patch set 2 CR +1 V +1 07/09/15, 10:24

  5. Christian Kuhn commented on patch set 2 CR +2 V +2 07/09/15, 10:28

    good to have some hands on in this area. reviewed, tested, works. thx!
  6. Christian Kuhn merged patch set 2 07/09/15, 10:28