Review main Merged Breaking

41063[!!!][TASK] Drop disableBigButtons in page module

Christian Kuhn CR +2 V +2 Normal +33 −169 updated 07/09/15, 22:10

Commit message

Disabling the by default enabled disableBigButtons TSconfig option
disables the option_showBigButtons property of PageLayoutView, so
some funny buttons in page module top bar and some misplaced buttons
to edit rte elements are enabled.

Easy, isn't it?!

This option is dropped now.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 4

Review log 14

  1. Christian Kuhn uploaded patch set 1 07/09/15, 20:46

  2. Christian Kuhn uploaded patch set 2 07/09/15, 20:50

  3. Christian Kuhn uploaded patch set 3 07/09/15, 20:53

  4. Wouter Wolters commented on patch set 3 07/09/15, 21:25

    PageLayoutView.php:503

    remove it here too. and than deprecate isRTEforField and getSpecConfForField

    PageLayoutView.php:1252

    drop second parameter?
  5. Christian Kuhn commented on patch set 3 CR -1 07/09/15, 21:29

    PageLayoutView.php:503 Reply

    ah true, will do.
  6. Christian Kuhn commented on patch set 3 07/09/15, 21:47

    PageLayoutView.php:503 Reply

    ah, funny. if these methods are obsolete as well, i'd rather remove all of them directly, since this will ease further refactorings if those dependencies vanish. should be acceptable trade-off.
  7. Christian Kuhn uploaded patch set 4 07/09/15, 21:51

  8. Christian Kuhn uploaded patch set 5 07/09/15, 21:55

  9. Christian Kuhn uploaded patch set 6 07/09/15, 21:58

  10. Markus Klein commented on patch set 6 CR -1 07/09/15, 22:04

    one more update from my side
  11. Markus Klein uploaded patch set 7 07/09/15, 22:07

  12. Markus Klein voted on patch set 7 V +1 CR +1 07/09/15, 22:08

  13. Wouter Wolters commented on patch set 7 V +2 CR +2 07/09/15, 22:09

    Looking good now. Lets get it in.
  14. Wouter Wolters merged patch set 7 07/09/15, 22:10