41063[!!!][TASK] Drop disableBigButtons in page module
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 4
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+0 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php4+4 −166
- typo3/sysext/core/Documentation/Changelog/master/Breaking-68020-DroppedDisableBigButtons.rstnew+29 −0
- typo3/sysext/t3editor/res/jslib/parse_typoscript/tokenizetyposcript.js+0 −2
Review log 14
-
Christian Kuhn uploaded patch set 1 07/09/15, 20:46
-
Christian Kuhn uploaded patch set 2 07/09/15, 20:50
-
Christian Kuhn uploaded patch set 3 07/09/15, 20:53
-
Wouter Wolters commented on patch set 3 07/09/15, 21:25
PageLayoutView.php:1252drop second parameter? -
Christian Kuhn commented on patch set 3 CR -1 07/09/15, 21:29
PageLayoutView.php:503Replyah true, will do. -
Christian Kuhn commented on patch set 3 07/09/15, 21:47
PageLayoutView.php:503Replyah, funny. if these methods are obsolete as well, i'd rather remove all of them directly, since this will ease further refactorings if those dependencies vanish. should be acceptable trade-off. -
Christian Kuhn uploaded patch set 4 07/09/15, 21:51
-
Christian Kuhn uploaded patch set 5 07/09/15, 21:55
-
Christian Kuhn uploaded patch set 6 07/09/15, 21:58
-
Markus Klein commented on patch set 6 CR -1 07/09/15, 22:04
one more update from my side -
Markus Klein uploaded patch set 7 07/09/15, 22:07
-
Markus Klein voted on patch set 7 V +1 CR +1 07/09/15, 22:08
-
Wouter Wolters commented on patch set 7 V +2 CR +2 07/09/15, 22:09
Looking good now. Lets get it in. -
Wouter Wolters merged patch set 7 07/09/15, 22:10
PageLayoutView.php:503