4109[BUGFIX] Show warning message if the open record changed during editing
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 13
- t3lib/tceforms/extdirect/class.t3lib_tceforms_extdirect_commands.php15new+72 −0
- t3lib/config_default.php+8 −1
- t3lib/core_autoload.php+1 −0
- typo3/js/tceforms.js4new+158 −0
- typo3/sysext/lang/locallang_tceform.xlf3new+44 −0
- typo3/sysext/lang/locallang_tceform.xml1new+20 −0
- typo3/sysext/t3skin/extjs/xtheme-t3skin.css2+10 −5
- typo3/sysext/dbal+1 −1
- typo3/sysext/extbase+1 −1
- typo3/sysext/fluid+1 −1
- typo3/sysext/version+1 −1
- typo3/sysext/workspaces+1 −1
- typo3/alt_doc.php4+4 −0
Review log 44
Show 19 earlier messages
-
Helmut Hummel commented on patch set 1 07/16/12, 19:32
I would prefer that you didn't submit this This is a nice FEATURE, but no bugfix. Thus it cannot into 4.5 and feature freeze for 4.6 also passed.please change to FEATURE. something like this: [FEATURE] Show warning message if the open record changed during editing -
Kay Strobach commented on patch set 1 07/16/12, 19:32
hi helmut, xavier has declared it as bugfix and scheduled (skype) it for beta2 (forge) personally. http://forge.typo3.org/issues/28618#note-5 It reduces the chance to get a lost update, which has been increased by the cardlayout - so this "bugfix" is related to the cardlayout ;) Regards KayReply
Done -
Kay Strobach commented on patch set 1 07/16/12, 19:32
still working on that stuff - it's not ready yet as there was a usability review by fabien -
Helmut Hummel commented on patch set 2 1 comment 07/16/12, 19:32
I would prefer that you didn't submit this Sorry, to me this is clearly a feature, which has nothing to do with the switch to the cards layout. It was like this for ages: 1. open a record to edit 2. fetch a coffe and have a 20 min break 3. continue working on it 4. in the meantime another editor opens the same record, getting a warning message 5. the other editor saves the record anyway 6. you also save 7. conflict It might be more prominent with the card layout, but really not too much. I don't say this feature isn't useful and I'm fine with making an exception for this feature (if Xavier agrees, as he seems to do), but it must NOT be committed stating that it is a bugfix. -
Kay Strobach commented on patch set 2 07/16/12, 19:32
(1 inline comment) -
Kay Strobach uploaded patch set 2 07/16/12, 19:32
-
Stefan Neufeind commented on patch set 3 07/16/12, 19:32
(6 inline comments) to best knowledge looks fine by reading; only small comments -
Kay Strobach uploaded patch set 3 07/16/12, 19:32
-
Kay Strobach uploaded patch set 4 07/16/12, 19:32
-
Kay Strobach uploaded patch set 5 07/16/12, 19:32
-
Kay Strobach commented on patch set 5 07/16/12, 19:32
xliff still missing - where is the converter? - can't find it in extdeval ... :( -
Helmut Hummel commented on patch set 6 07/16/12, 19:32
@Christopher: Can you explain to me how you can NEWLY open a record and still get old content? I understand that when you opened a record with the page module, then switch to the list module, open the same record, save it, then switch back to the page module you see the old content. But opening a record (which loads alt_doc.php) always reflects the current record state, doesn't it? -
Helmut Hummel commented on patch set 6 07/16/12, 19:32
@Kay: Well, that's exactly what I am saying. It has been like this ever before and has not much to do with the card layout (but I agree that it is a bit more prominent now). If you edit a record in the upper right corner there is a button which opens this record in a new window. If you do this and go back to the original window and continue editing the same record you have exactly the same problem, it was there for "ages". But OK it is a nice feature and I will not discuss the commit message any more, no one will care until it is merged anyway. -
Georg Ringer commented on patch set 6 11 comments 07/16/12, 19:32
Do not submit -
Kay Strobach uploaded patch set 6 07/16/12, 19:32
-
Kay Strobach commented on patch set 6 07/16/12, 19:32
@helmut: http://forge.typo3.org/issues/28618#note-13 Thinking again of Use Case no 2 (the second wireframe), I still don't see the relevance of this feature and would be against it at this stage. The Card Layout which has been introduced in TYPO3 4.6 does not change the situation, I believe. From the Use Case which has been provided by Chat: You start editing in the pagemodule switch to listmodule and edit some stuff (e.g 20 minutes) in this time another user starts to edit the page record (but don't save it) you switch back to the pagemodule during the other guys edits the page ... then we could have a lost update ... In the step no 3, a third User will be informed anyway the record is under edition and it is his responsibility if he is starting editing. In my eyes, the message should be displayed only if the record has been changed in the database (read: the record was saved in the mean time). Back to your request: 1. clear message (for case 1 and 2) First draft (which will need to be confirmed): Title: News "Lorem Ipsum..." has been changed Message: This page contains unsaved changes. Would you like to reload the page and loose your changes or stay on this page and <link>check out</link> the difference? Buttons: [Reload] [Stay on this page] 2. should it be possible to open the current tceform in a popup window, directly from the messagebox) Yes, this is a very good thing according to me. Cf. message 3. should we think about the merging wizard Just to see the problem the other way around: shouldn't we rather think of a collaborative way of editing rather than handling conflicts ;) Probably difficult but I wonder to which extend such feature would be implementable for a textarea / input field. -
Kay Strobach commented on patch set 6 07/16/12, 19:32
(8 inline comments) -
Kay Strobach commented on patch set 6 07/16/12, 19:32
mhmm with the original cardlayout commit it was very prominent, but with the commited version (more agressive reloads) it's not so problematic anymore. But there still reasons to have this feature in TYPO3 - as you see ;) Thanks for reviewing ;) -
Kay Strobach commented on patch set 7 07/16/12, 19:32
language file still under review :(
-
Kay Strobach uploaded patch set 7 07/16/12, 19:32
-
Georg Ringer commented on patch set 8 07/16/12, 19:32
still a blocker, see comments. for discussion about ctrl/tstamp, maybe switch to core list or so? -
Kay Strobach uploaded patch set 8 07/16/12, 19:32
-
Tolleiv Nietsch commented on patch set 9 07/16/12, 19:32
Do not submit Kay any update or should we abandon it for now? -
Stefan Neufeind commented on patch set 9 07/16/12, 19:32
Any chance to get this review going again, folks? -
Stefan Neufeind commented on patch set 9 07/16/12, 19:32
well, sounds like a nice suggestion to me. In case people don't really like the polling-idea, maybe we could make that optional but still use the merging-step when submitting and finding out there was a save inbetween? besides manual merging, would even a display of what changed with an "automatic" merge be viable? -
Stefan Neufeind commented on patch set 9 07/16/12, 19:32
We should keep it simple for now imho. Just "some" method to display diffs. You might want to take a look at how the workspaces show what changed and we might add a common diff-display for all those places later. -
Marcus Schwemer commented on patch set 9 07/16/12, 19:32
Since the issue on forge is rejected and the reviews were for 4.6, postponed to 4.7 and we are working on 6.0, this review can be IMHO abandoned. @Kay: Can you do this? Ciao, Marcus P.S.: I just try to reduce the number of open reviews. Currently there are more then 200 open. -
Xavier Perseguers commented on patch set 9 07/16/12, 19:32
Do not submit Postponed to 4.7 -
Georg Ringer commented on patch set 9 4 comments 07/16/12, 19:32
No score -
Kay Strobach commented on patch set 9 07/16/12, 19:32
i reworked most of the stuff locally already - please be patiend for some days ;) - sry, but i had other stuff to do in the last weeks :( -
Kay Strobach uploaded patch set 9 07/16/12, 19:32
-
Kay Strobach commented on patch set 9 07/16/12, 19:32
the question is, is that feature still wanted? - it sounds if not in the meantime - would be glad to get a feedback of the core team here, than i can fix all the mentioned things -
Kay Strobach commented on patch set 9 07/16/12, 19:32
the last version just opened a window with the current state of the form, but using t3lib_diff this should be theoretically possible for simple form fields, but what's about IRRE, other complex multitable fieldtypes? So it currently just says, that the record has changed and sb. different has left the following state ;) -
Chris topher commented on patch set 3 V 0 07/16/12, 19:32
IMO this is a bugfix. The bug is that when you NEWLY open a record, you still get old content. That is an issue, which was not(!) present in older releases. It's a cleanup/optimization of what's there. The patch basically looks good, but please use an XLIFF file instead of XML (locallang_tceform.xml). Here is an example: http://forge.typo3.org/projects/extension-linkvalidator/repository/revisions/ad08acff7c7dec1bc8742ff7e78b3defb1e41b9c For the rest see inline comments (nearly only CGL).class.t3lib_tceforms_extdirect_commands.php:37Typo: it's => itsclass.t3lib_tceforms_extdirect_commands.php:382 typos: wether => whether and records => recordalt_doc.php:455Whitespaces behind comma.tceforms.js:39someone elsetceforms.js:112Typo: windows => windowlocallang_tceform.xml:1Please use an XLIFF file instead of an XML file.xtheme-t3skin.css:2212Newline intended? If so: OK. -
Mr. Jenkins commented on patch set 1 07/16/12, 19:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1573/ : SUCCESS -
Mr. Jenkins commented on patch set 2 07/16/12, 19:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1576/ : SUCCESS -
Mr. Jenkins commented on patch set 3 07/16/12, 19:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1588/ : SUCCESS -
Mr. Jenkins commented on patch set 4 07/16/12, 19:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1739/ : SUCCESS -
Mr. Jenkins commented on patch set 5 07/16/12, 19:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1740/ : SUCCESS -
Mr. Jenkins commented on patch set 6 07/16/12, 19:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1754/ : SUCCESS -
Mr. Jenkins commented on patch set 7 07/16/12, 19:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1979/ : SUCCESS -
Mr. Jenkins commented on patch set 8 07/16/12, 19:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1980/ : SUCCESS -
Mr. Jenkins commented on patch set 9 07/16/12, 19:32
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1981/ : SUCCESS -
Kay Strobach commented on patch set 9 07/16/12, 19:32
Abandoned skipped