Review main Merged

41102[TASK] Drop migration code in Install Tool

Wouter Wolters CR +2 V +2 Normal +3 −117 updated 07/13/15, 09:01

Commit message

The code which migrates the old localconf.php file is dropped now.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 12

  1. Wouter Wolters uploaded patch set 1 07/11/15, 16:30

  2. Wouter Wolters uploaded patch set 2 07/11/15, 16:31

  3. Georg Ringer voted on patch set 2 CR +1 07/11/15, 20:47

  4. David Greiner voted on patch set 2 CR +1 V +1 07/12/15, 12:11

  5. Stefan Neufeind commented on patch set 2 CR +1 07/12/15, 14:14

    I'm fine with that. And imho it's clear that for migrating from 4.5 to 7 you'll need to take a 6.2-step inbetween.
  6. Markus Klein updated the commit message in patch set 3 07/12/15, 20:36

  7. Markus Klein commented on patch set 3 07/12/15, 20:37

    StepController.php:51

    recreatePackageStatesFileIfNotExisting
  8. Christian Kuhn uploaded patch set 4 07/13/15, 08:57

  9. Christian Kuhn commented on patch set 3 07/13/15, 08:58

    StepController.php:51 Reply

    Done
  10. Christian Kuhn voted on patch set 4 CR +1 V +1 07/13/15, 08:59

  11. Helmut Hummel voted on patch set 4 CR +2 V +2 07/13/15, 09:01

  12. Helmut Hummel merged patch set 4 07/13/15, 09:01