41110[TASK] Remove ternary operator where not needed
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Markus Klein +1
-
Verified V +2
- Stefan Neufeind +2
- Markus Klein +1
Issues 1
Files 40
- typo3/sysext/backend/Classes/Backend/ToolbarItems/HelpToolbarItem.php1+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormLanguageContainer.php1+1 −1
- typo3/sysext/backend/Classes/Form/Container/FullRecordContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+3 −3
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+2 −2
- typo3/sysext/backend/Classes/Form/ElementConditionMatcher.php+1 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php1+1 −1
- typo3/sysext/backend/Classes/Utility/IconUtility.php+3 −3
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+2 −2
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php1+3 −3
- typo3/sysext/core/Classes/ExtDirect/ExtDirectApi.php1+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+3 −7
- typo3/sysext/extbase/Classes/Mvc/Cli/Request.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Request.php+1 −2
- typo3/sysext/fluid/Classes/Core/Parser/TemplateParser.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+4 −7
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
Show 20 more files
- typo3/sysext/frontend/Classes/Http/EidRequestHandler.php+1 −1
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+20 −20
- typo3/sysext/frontend/Classes/Utility/EidUtility.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchFormController.php+4 −1
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+1 −1
- typo3/sysext/indexed_search/Classes/Indexer.php+2 −2
- typo3/sysext/install/Classes/Controller/Action/Tool/AllConfiguration.php+2 −2
- typo3/sysext/lang/Classes/Domain/Model/Language.php+1 −1
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+1 −1
- typo3/sysext/recycler/Classes/Utility/RecyclerUtility.php+2 −2
- typo3/sysext/rtehtmlarea/Classes/Extension/Spellchecker.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Salt/BlowfishSalt.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Salt/Md5Salt.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Salt/PhpassSalt.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
- typo3/sysext/t3editor/Classes/Hook/TypoScriptTemplateInfoHook.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+1 −1
- typo3/sysext/workspaces/Classes/ExtDirect/ActionHandler.php+1 −1
Review log 9
-
Stefan Neufeind uploaded patch set 1 07/12/15, 15:00
-
Stefan Neufeind commented on patch set 1 07/12/15, 15:00
In some cases we might even consider just using a conversion with (bool)? Markus, what do you think? -
Markus Klein updated the commit message in patch set 2 07/12/15, 20:29
-
Markus Klein commented on patch set 2 07/12/15, 20:34
Just commented on a few. General rule should be (bool)$somevar or (bool)$this->someMember !empty($array['index'])HelpToolbarItem.php:51using isset() here can be a change of behaviour. pls change this to (bool)FlexFormLanguageContainer.php:50simple (bool) cast, empty() not needed hereDocumentTemplate.php:1886(bool)DataHandler.php:3115(bool)ExtDirectApi.php:154(bool) -
Stefan Neufeind uploaded patch set 3 07/13/15, 19:03
-
Markus Klein uploaded patch set 4 07/13/15, 19:42
-
Markus Klein voted on patch set 4 CR +1 V +1 07/13/15, 19:43
-
Stefan Neufeind commented on patch set 4 CR +2 V +2 07/13/15, 19:44
checked by reading with Markus -
Stefan Neufeind merged patch set 4 07/13/15, 19:45