Review main Merged

41110[TASK] Remove ternary operator where not needed

Stefan Neufeind CR +2 V +2 Normal +80 −85 updated 07/13/15, 19:45

Commit message

The usage of the ternary operator just for conversion to boolean like
... ? TRUE : FALSE
is be replaced by a normal (bool) typecast.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1

Issues 1

Files 40

Show 20 more files

Review log 9

  1. Stefan Neufeind uploaded patch set 1 07/12/15, 15:00

  2. Stefan Neufeind commented on patch set 1 07/12/15, 15:00

    In some cases we might even consider just using a conversion with (bool)? Markus, what do you think?
  3. Markus Klein updated the commit message in patch set 2 07/12/15, 20:29

  4. Markus Klein commented on patch set 2 07/12/15, 20:34

    Just commented on a few. General rule should be (bool)$somevar or (bool)$this->someMember !empty($array['index'])

    HelpToolbarItem.php:51

    using isset() here can be a change of behaviour. pls change this to (bool)

    FlexFormLanguageContainer.php:50

    simple (bool) cast, empty() not needed here

    DocumentTemplate.php:1886

    (bool)

    DataHandler.php:3115

    (bool)

    ExtDirectApi.php:154

    (bool)
  5. Stefan Neufeind uploaded patch set 3 07/13/15, 19:03

  6. Markus Klein uploaded patch set 4 07/13/15, 19:42

  7. Markus Klein voted on patch set 4 CR +1 V +1 07/13/15, 19:43

  8. Stefan Neufeind commented on patch set 4 CR +2 V +2 07/13/15, 19:44

    checked by reading with Markus
  9. Stefan Neufeind merged patch set 4 07/13/15, 19:45