Review main Merged

41116[BUGFIX] Notify about wrong backend user group setting

Nicole Hummel CR +2 V +2 Normal +82 −0 updated 07/14/15, 21:58

Commit message

An editor can't edit a plugin as long as the page content type "Insert
Plugin" isn't allowed for the backend user group even if the access to
a plugin is defined. This patch adds a notification about missing
configuration to improve usability for integrators.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Susi Moog +1
  • Verified V +2
    • Wouter Wolters +2
    • Susi Moog +1

Issues 1

Files 3

Review log 11

  1. Nicole Hummel uploaded patch set 1 07/13/15, 09:30

  2. Nicole Hummel updated the commit message in patch set 2 07/13/15, 09:37

  3. Nicole Hummel uploaded patch set 3 07/13/15, 09:57

  4. Susi Moog voted on patch set 3 CR +1 V +1 07/13/15, 10:31

  5. Wouter Wolters voted on patch set 3 CR +1 07/13/15, 10:40

  6. Christian Kuhn commented on patch set 3 07/13/15, 13:51

    BackendUserGroupIntegrityCheck.php:30

    this is no the message i was looking for ;)

    BackendUserGroupIntegrityCheck.php:32

    why a singleton?
  7. Nicole Hummel uploaded patch set 4 07/13/15, 15:34

  8. Nicole Hummel commented on patch set 3 07/13/15, 15:35

    BackendUserGroupIntegrityCheck.php:30 Reply

    Done

    BackendUserGroupIntegrityCheck.php:32 Reply

    Thought about having only one instance here. But DataHandler stores all hook objects in an own array, so I removed SingletonInterface.
  9. Susi Moog voted on patch set 4 CR +1 V +1 07/14/15, 11:12

  10. Wouter Wolters voted on patch set 4 V +2 CR +2 07/14/15, 21:58

  11. Wouter Wolters merged patch set 4 07/14/15, 21:58