Review main Merged

41143[FEATURE] Adjust trustedHostsPattern during installation

Nicole Hummel CR +2 V +2 Normal +86 −6 updated 07/15/15, 18:38

Commit message

During the installation the trusted hosts pattern check is disabled
by default. This leads to an exception after the installation on entering
the login form. This patch adds hosts checks to install tool and reports
module to ensure the installation is working after install process.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1

Issues 1

Files 6

Review log 10

  1. Nicole Hummel uploaded patch set 1 07/13/15, 19:30

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 07/13/15, 20:28

  3. Mathias Schreiber commented on patch set 1 07/13/15, 21:12

    Check.php:161

    The trusted hosts pattern has been configured to allow all header values. This is because your $SERVER_NAME is [htmlspecialchars(SERVER_NAME)] while your HTTP_HOST is [htmlspecialchars(HTTP_HOST)]. Check the pattern defined in Install Tool -> All configuration -> System -> trustedHostsPattern and adapt it to expected host value(s).
  4. Nicole Hummel uploaded patch set 2 07/13/15, 21:35

  5. Helmut Hummel commented on patch set 2 07/13/15, 21:46

    GeneralUtility.php:3530

    please add a short description and mark it as @internal
  6. Nicole Hummel uploaded patch set 3 07/14/15, 13:08

  7. Mathias Schreiber voted on patch set 3 CR +1 V +1 07/15/15, 18:28

  8. Benni Mack voted on patch set 3 CR +2 07/15/15, 18:37

  9. Benni Mack voted on patch set 3 V +2 07/15/15, 18:38

  10. Benni Mack merged patch set 3 07/15/15, 18:38