Review main Merged

41170[BUGFIX] Streamline calls to sysLog

Tymoteusz Motylewski CR +2 V +2 Normal +41 −36 updated 07/14/15, 19:06

Commit message

Make all calls to GeneralUtility::sysLog use extkey "core"
instead of "Core".
Use constants for severity levels.
Fix wrong parameters (message instead of extension key).

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Georg Ringer +1
  • Verified V +2
    • Stefan Neufeind +2
    • Georg Ringer +1

Issues 1

Files 12

Review log 9

  1. Tymoteusz Motylewski uploaded patch set 1 07/14/15, 09:41

  2. Markus Klein updated the commit message in patch set 2 07/14/15, 10:04

  3. Markus Klein commented on patch set 2 07/14/15, 10:12

    GridDataService.php:366

    param missing?
  4. Tymoteusz Motylewski commented on patch set 2 07/14/15, 12:14

    GridDataService.php:366 Reply

    yes, indeed, the extension key is missing. Nice catch! I have focused on the constants and missed this one.
  5. Tymoteusz Motylewski uploaded patch set 3 07/14/15, 18:32

  6. Tymoteusz Motylewski uploaded patch set 4 07/14/15, 18:33

  7. Georg Ringer voted on patch set 4 CR +1 V +1 07/14/15, 18:57

  8. Stefan Neufeind voted on patch set 4 CR +2 V +2 07/14/15, 19:06

  9. Stefan Neufeind merged patch set 4 07/14/15, 19:06