Review main Merged Breaking

41206[!!!][TASK] Remove magic quote handling from $_GET / $_POST

Benni Mack CR +2 V +2 Normal +58 −47 updated 08/07/15, 12:59

Commit message

The magic quote functionality was removed with PHP 5.4.0.
In previous PHP versions this was a switch to turn on/off adding
slashes to the _GET and _POST superglobals.

TYPO3 however was always adding slashes at every request
and using GeneralUtility::_GP() etc. to remove the slashes again.

As the PHP functionality is now removed, meaning there are no
slashes added at all, TYPO3 can now use the non-slashed data
inside the superglobals directly.

Review

  • Code review CR +2
    • Susi Moog +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1
    • Wouter Wolters +1

Issues 1

Files 7

Review log 10

  1. Benni Mack uploaded patch set 1 07/14/15, 14:28

  2. Benni Mack uploaded patch set 2 07/17/15, 09:17

  3. Benni Mack uploaded patch set 3 07/17/15, 10:01

  4. Benni Mack uploaded patch set 4 08/06/15, 22:04

  5. Wouter Wolters voted on patch set 4 CR +1 08/06/15, 22:16

  6. Georg Ringer voted on patch set 4 CR +1 V +1 08/07/15, 04:48

  7. Wouter Wolters voted on patch set 4 V +1 08/07/15, 08:35

  8. Susi Moog voted on patch set 4 CR +2 V +2 08/07/15, 08:46

  9. Susi Moog merged patch set 4 08/07/15, 08:46

  10. Stefan Neufeind commented on patch set 5 08/07/15, 12:59

    nice one, +1