Review main Merged

41218[BUGFIX] Fix parseUserFuncArguments to respect 0 as argument

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 07/14/15, 17:19

Commit message

"0" must be an valid "last argument" value in the parseUserFuncArguments
method.

The implementation of the argument iteration must strictly check if
the arguments string is empty.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1

Issues 2

Files 1

Review log 5

  1. Sascha Egerer uploaded patch set 1 07/14/15, 16:00

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 07/14/15, 17:15

  3. Benni Mack voted on patch set 1 CR +2 V +2 07/14/15, 17:18

  4. Benni Mack merged patch set 1 07/14/15, 17:18

  5. Benni Mack commented on patch set 2 07/14/15, 17:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 0565e8b810fd2ee762db73512f15aca67775a530