Review main Merged

41247[TASK] Move Backend AJAX Calls to index.php

Benni Mack CR +2 V +2 Normal +62 −15 updated 07/15/15, 09:34

Commit message

The typo3/ajax.php entrypoint is removed in favor of
checking for ajaxID in all backend requests inside the Backend
Application.

The request object from the server is now enhanced with the
information inside the application which type is now called.

In this course, the GeneralUtility::isInternalRequestType()
is extended to return ture if no request type constant is set
due to early calls to GeneralUtility methods when building the
ServerRequest object with a Uri object.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 7

Review log 8

  1. Benni Mack uploaded patch set 1 07/14/15, 21:21

  2. Georg Ringer updated the commit message in patch set 2 07/14/15, 21:25

  3. Wouter Wolters commented on patch set 1 07/14/15, 21:27

    return true

    index.php:16

    entry can be lowercase

    AjaxRequestHandler.php:28

    We use $GLOBALS['TYPO3_CONF_VARS'] normally..

    Deprecation-68141-Typo3ajaxphp.rst:8

    deprecated.as they automatically use index.php
  4. Wouter Wolters commented on patch set 2 CR -1 07/14/15, 21:28

    Please see comment on PS1
  5. Benni Mack uploaded patch set 3 07/14/15, 21:59

  6. Wouter Wolters voted on patch set 3 V +1 CR +1 07/14/15, 22:00

  7. Georg Ringer voted on patch set 3 CR +2 V +2 07/15/15, 09:34

  8. Georg Ringer merged patch set 3 07/15/15, 09:34