Review main Abandoned

41263[TASK] Use fallbacks for AbstractWidgetController view-configuration

Marc Bastian Heinrichs CR 0 V 0 Normal +90 −5 updated 03/05/16, 09:18

Commit message

The fallback-paths functionality offered by the parent class
is now available for Fluid-widgets.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 10

  1. Marc Bastian Heinrichs uploaded patch set 1 07/15/15, 08:39

  2. Marc Bastian Heinrichs commented on patch set 1 07/15/15, 08:41

    Untested idea
  3. Marc Bastian Heinrichs commented on patch set 1 07/15/15, 08:51

    BTW. Do we want to do this breaking? With this one there is also an non breaking version possible I guess.
  4. Sebastian Michaelsen commented on patch set 1 07/18/15, 09:59

    Breaking-59505-UseFallbacksForAbstractWidgetControllerView-configuration.rst:26

    widgets
  5. Marc Bastian Heinrichs uploaded patch set 2 07/20/15, 21:27

  6. Marc Bastian Heinrichs commented on patch set 2 07/20/15, 21:29

    Georg, news admin paginator still works now.
  7. Marc Bastian Heinrichs commented on patch set 2 07/20/15, 21:33

    Did not checked the tests.
  8. Benni Mack wrote 08/13/15, 14:36

    Topic set to EXT: fluid
  9. Claus Due commented on patch set 2 CR -1 09/23/15, 22:15

    I'm not sure we should have this. Few reasons: * Standalone Fluid reintegration project has added what was missing before: plural path supports for Widgets. * These multiple paths should be explicitly defined as paths for the actual class - rather than magically inherited. If you agree with the second assessment I suggest abandoning this patch (and noting in documentation that plural paths are now supported for Widgets too, but that's another discussion).
  10. Benni Mack abandoned the change 03/05/16, 09:18

    abandoned as no feedback got in, and we now have fluid standalone.