Review main Merged

41264[TASK] Remove @author lines

Markus Klein CR +2 V +2 Nightmare +40 −3010 updated 07/15/15, 10:15

Commit message

@author information can be found in version control.
Cluttering our code with these tags does not make much
sense and they are outdated by definition or would sum
up to impressive lists.

As decided on acme 2015, we drop them now.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1284

Show 1264 more files

Review log 21

  1. Markus Klein uploaded patch set 1 07/15/15, 09:14

  2. Markus Klein uploaded patch set 2 07/15/15, 09:29

  3. Markus Klein uploaded patch set 3 07/15/15, 09:31

  4. Christian Kuhn commented on patch set 3 07/15/15, 09:36

    BrowseTreeView.php:23

    let us remove @coauthor, too.
  5. Georg Ringer voted on patch set 3 CR +1 V +1 07/15/15, 09:40

  6. Wouter Wolters uploaded patch set 4 07/15/15, 09:44

  7. Wouter Wolters voted on patch set 4 V +1 CR +1 07/15/15, 09:44

  8. Christian Kuhn commented on patch set 4 07/15/15, 09:47

    Rfc822AddressesParser.php:42

    maybe we should keep these ... and, since this looks like 3rd party code, we may want to have a look if it is still needed or could be refactored out, or if we could switch to a composer dependency.

    RemoveXSS.php:19

    maybe keep this single one ... removexss will fall anyway, hopefully.
  9. Christian Kuhn commented on patch set 4 07/15/15, 09:53

    Indexer.php:24

    double header

    Lexer.php:21

    double header
  10. Christian Kuhn commented on patch set 4 07/15/15, 09:55

    OpenID.php:15

    leave it out for all the openid 3rd party files?
  11. Christian Kuhn commented on patch set 4 07/15/15, 09:58

    done with review.
  12. Wouter Wolters uploaded patch set 5 07/15/15, 10:06

  13. Wouter Wolters voted on patch set 5 V +1 CR +1 07/15/15, 10:07

  14. Christian Kuhn voted on patch set 5 CR +1 V +1 07/15/15, 10:09

  15. Christian Kuhn voted on patch set 5 CR +2 V +2 07/15/15, 10:11

  16. Christian Kuhn voted on patch set 5 CR -1 07/15/15, 10:11

  17. Christian Kuhn updated the commit message in patch set 6 07/15/15, 10:13

  18. Christian Kuhn voted on patch set 6 CR +1 V +1 07/15/15, 10:13

  19. Wouter Wolters voted on patch set 6 V +1 CR +1 07/15/15, 10:14

  20. Christian Kuhn voted on patch set 6 CR +2 V +2 07/15/15, 10:14

  21. Christian Kuhn merged patch set 6 07/15/15, 10:15