Review main Merged

41312[BUGFIX] Show remaining chars for InputElement only if defined

Georg Ringer CR +2 V +2 Easy +3 −2 updated 07/15/15, 15:51

Commit message

If no max is defined in the TCA the remaining characters can not be
determined without checking the DB. It is not a good idea to show a
hardcoded size of 256.

Change the code to be in sync with the TextElement and check the max
configuration first.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 5

  1. Georg Ringer uploaded patch set 1 07/15/15, 15:34

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 07/15/15, 15:36

  3. Frank Nägler voted on patch set 1 CR +1 07/15/15, 15:49

  4. Frank Nägler voted on patch set 1 CR +2 V +2 07/15/15, 15:51

  5. Frank Nägler merged patch set 1 07/15/15, 15:51