Review main Merged

41329[FEATURE] Paths to document root can be specified in composer.json

Helmut Hummel CR +2 V +2 Easy +48 −1 updated 07/22/15, 06:54

Commit message

With the new composer installer it is possible to specify the path of the document root
and also the path of the typo3/cms package

It can be specified in the extra section of your composer root package like that:

	"extra": {
		"typo3/cms": {
			"cms-package-dir": "{$vendor-dir}/typo3/cms",
			"web-dir": "web"
		}
	}

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 1

Files 2

Review log 12

  1. Helmut Hummel uploaded patch set 1 07/15/15, 18:44

  2. Benni Mack commented on patch set 1 CR +1 07/15/15, 19:28

    KILLER FEATURE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
  3. Helmut Hummel uploaded patch set 2 07/15/15, 19:40

  4. Wouter Wolters commented on patch set 2 CR -1 07/15/15, 19:46

    Update incoming

    Feature-68184-PathsToTypo3cmsPackageAndDocumentRootCanBeSpecifiedInComposerjson.rst:13

    without brackets :)
  5. Wouter Wolters uploaded patch set 3 07/15/15, 19:47

  6. Benni Mack voted on patch set 3 CR +1 V +1 07/15/15, 19:48

  7. Stefan Neufeind commented on patch set 3 CR +1 07/15/15, 19:49

    Got a walk through the code by Benni - thanks.
  8. Wouter Wolters voted on patch set 3 V +2 CR +2 07/15/15, 19:57

  9. Wouter Wolters merged patch set 3 07/15/15, 19:57

  10. Mathias Brodala commented on patch set 4 07/21/15, 11:09

    Anyone opposed to backporting this to 6.2? ATM one has to use something like "dev-master as 1.1.4" or "1.2.2 as 1.1.4" to use the newer installers for 6.2. An alias like "^1.2.2 as 1.1.4" is not supported by Composer.
  11. Helmut Hummel commented on patch set 4 07/21/15, 15:58

    > Anyone opposed to backporting this to 6.2 Yes. You can use it like described "1.2.2 as 1.1.4" would be the recommended setup. We may backport that at a later point maybe, but I would rather concentrate on testing that and let is stabilize in master first.
  12. Mathias Brodala commented on patch set 4 07/22/15, 06:54

    > You can use it like described "1.2.2 as 1.1.4" would be the recommended setup. That requires constant changes for every new release but I guess it'll do for now. > We may backport that at a later point maybe, but I would rather concentrate on testing that and let is stabilize in master first. Gotcha.