Review main Merged

41512[TASK] Replace revert_* Icons in RecordHistory.php with Buttons

Jan Helke CR +2 V +2 Easy +1 −1 updated 07/16/15, 21:49

Commit message

As the icons are not longer used, they could also be removed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Daniel Maier +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Maier +1

Issues 1

Files 4

Review log 10

  1. Jan Helke uploaded patch set 1 07/16/15, 20:22

  2. Daniel Maier voted on patch set 1 V -1 07/16/15, 20:34

  3. Daniel Maier commented on patch set 1 07/16/15, 20:36

    Hi Jan, with the new buttons, layout looks a little bit broken. There is some space missing between the buttons and the text after them.
  4. Jan Helke commented on patch set 1 07/16/15, 20:50

    To be honest: that is not an issue of this patch :-) The layout is far away from nice. I would prefer to push that into the core, to get rid of the images and open a new Issue "Make >Show record history< looks pretty".
  5. Daniel Maier commented on patch set 1 CR +1 V +1 07/16/15, 20:52

    Valid argument. So let's get in this one, and do a followup for the layout later.
  6. Benni Mack voted on patch set 1 CR +2 07/16/15, 21:45

  7. Christian Kuhn commented on patch set 1 CR -1 07/16/15, 21:46

    will test now.
  8. Wouter Wolters voted on patch set 1 CR +1 07/16/15, 21:47

  9. Christian Kuhn voted on patch set 1 CR +2 V +2 07/16/15, 21:49

  10. Christian Kuhn merged patch set 1 07/16/15, 21:49