Review main Merged

41518[BUGFIX] Improve detection of installed setup

Benni Mack CR +2 V +2 Easy +2 −2 updated 07/18/15, 12:19

Commit message

When installing TYPO3 via composer and installing
an extension at the same time, the install tool cannot
be called after that, as the typo3conf/ directory already
exists.

The check is optimized to check for the LocalConfiguration.php
and PackageStates.php which are not present at first install.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Jan Helke +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 2

Review log 8

  1. Benni Mack uploaded patch set 1 07/16/15, 21:35

  2. Wouter Wolters voted on patch set 1 CR +1 07/17/15, 08:45

  3. Jan Helke voted on patch set 1 CR +1 07/17/15, 08:47

  4. Susi Moog voted on patch set 1 CR +1 V +1 07/18/15, 11:44

  5. Christian Kuhn commented on patch set 1 CR -1 07/18/15, 11:57

    testing now.
  6. Benni Mack commented on patch set 1 07/18/15, 11:58

    you can test it with this composer.json and just do a "composer install" { "repositories": [ { "type": "composer", "url": "http://composer.typo3.org/"; } ], "name": "bmack/typo3-base-distribution", "description" : "TYPO3 CMS Benni Distribution", "config": { "bin-dir": "bin" }, "require": { "typo3/cms": "dev-master as 7.5.0", "typo3-ter/news": "^3.2" }, "extra": { "typo3/cms": { "cms-package-dir": "{$vendor-dir}/typo3/cms", "web-dir": "Web" } } }
  7. Christian Kuhn voted on patch set 1 CR +2 V +2 07/18/15, 12:17

  8. Christian Kuhn merged patch set 1 07/18/15, 12:19