Review main Merged

41557[TASK] Move language in saltedpasswords

Michael Oehlhof CR +2 V +2 Easy +8 −8 updated 07/17/15, 13:49

Commit message

Moved language files in saltedpasswords to Resources/Private/Language

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1

Issues 1

Files 7

Review log 9

  1. Michael Oehlhof uploaded patch set 1 07/17/15, 10:46

  2. Wouter Wolters commented on patch set 1 CR -1 07/17/15, 11:15

    I think you forgot to add the moved files again.
  3. Michael Oehlhof uploaded patch set 2 07/17/15, 11:20

  4. Stefan Neufeind voted on patch set 2 CR +1 07/17/15, 12:37

  5. Stefan Neufeind commented on patch set 2 V +1 07/17/15, 13:35

    verified by applying the patch and searching across the code for overlooked replacements
  6. Wouter Wolters voted on patch set 2 V +2 CR +2 07/17/15, 13:36

  7. Stefan Neufeind commented on patch set 2 07/17/15, 13:47

    please wait for Andreas ... currently testing
  8. Andreas Wolf merged patch set 2 07/17/15, 13:49

  9. Andreas Wolf commented on patch set 3 07/17/15, 13:49

    Also tested it by creating the scheduler task and checking the extension manager.