Review main Abandoned

41574[BUGFIX] Set headerOnly should not remove search words

Benni Mack CR 0 V 0 Easy +2 −2 updated 07/17/15, 20:39

Commit message

When setting the headerOnly parameter of the function printResultRow
to one (which should be made configurable via TS if it isn`t already),
makeDescription function is not called any more.

This results in a search result where a description without
marked-up search-words is generated.

The patch fixes the behaviour.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 4

  1. Benni Mack uploaded patch set 1 07/17/15, 14:52

  2. Benni Mack wrote 07/17/15, 14:52

    Topic set to indexed_search
  3. Patrick Kollodzik commented on patch set 1 V -1 07/17/15, 20:38

    The output before the patch looks more correct then with this patch. With this patch normal search results for pages will be missing the meta description and only use the content.
  4. Stefan Neufeind abandoned the change 07/17/15, 20:39

    This leads nowhere ... old issue, not reproducible.