Review main Merged

41587[TASK] Set suggestWizard.searchWholePhrase default to TRUE

Frans Saris CR +2 V +2 Easy +38 −1 updated 07/19/15, 09:31

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1

Issues 1

Files 2

Review log 10

  1. Frans Saris uploaded patch set 1 07/17/15, 18:01

  2. Benni Mack voted on patch set 1 CR +1 V +1 07/17/15, 23:06

  3. Andreas Wolf commented on patch set 1 CR -1 07/17/15, 23:46

    I intentionally did not do this back when I implemented this feature as it might have severe performance implications (fulltext LIKE matching with wildcard at the start was regarded to be slow back then). This might have changed, but I would love to see some numbers first before merging this.
  4. Markus Sommer voted on patch set 1 CR +1 V +1 07/18/15, 10:36

  5. Andreas Wolf uploaded patch set 2 07/19/15, 07:44

  6. Andreas Wolf commented on patch set 2 V +1 CR +1 07/19/15, 07:45

    Fixed a wrongly placed typecast and elaborated the documentation.
  7. Markus Klein uploaded patch set 3 07/19/15, 07:53

  8. Markus Klein voted on patch set 3 CR +1 V +1 07/19/15, 07:53

  9. Georg Ringer voted on patch set 3 CR +2 V +2 07/19/15, 09:31

  10. Georg Ringer merged patch set 3 07/19/15, 09:31