41606[TASK] Get rid of clear.gif in buttons
Commit message
Review
-
Code review CR -1
- Anja Leichsenring +2
- Wouter Wolters +1
- Frank Nägler -1
- Sascha Wilking +1
-
Verified V +2
- Anja Leichsenring +2
- Stefan Neufeind +1
- Wouter Wolters +1
- Sascha Wilking +1
Issues 2
Files 9
- Build/Resources/Public/Less/TYPO3/_element_docheader.less+2 −0
- Build/Resources/Public/Less/TYPO3/_icons.less+3 −2
- typo3/sysext/backend/Classes/Controller/Wizard/RteController.php+9 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php3+4 −4
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+6 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+4 −4
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+3 −1
- typo3/sysext/t3skin/Resources/Public/Css/backend.css+3 −0
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php1+9 −7
Review log 31
Show 6 earlier messages
-
Jan Helke uploaded patch set 1 07/17/15, 20:41
-
Stefan Neufeind commented on patch set 1 CR -1 V -1 07/17/15, 23:22
Can't work by just removing the src-attribute. I agree it might be best to keep the <input>-tags. But we should maybe switch from type="image" to type="submit" and color:transparent. If you don't set the color (at least) Firefox tries to display the "title" on the "button". -
Stefan Neufeind commented on patch set 1 CR -2 07/17/15, 23:38
I just talked to Benni how we'll solve that. I'll provide a patch ... -
Stefan Neufeind uploaded patch set 2 07/18/15, 01:31
-
Stefan Neufeind commented on patch set 2 CR 0 07/18/15, 01:35
Benni said that <button> was the way to go and there should be some few parts already in the core. I found examples of some few buttons like we have and did the ones here in the same style. Unfortunately it still needs margin/padding:0px (actually just padding) because otherwise buttons would have 6px space on the left/right side. We might want to solve that different - let's talk to the layout-team in the morning ... -
Jan Helke voted on patch set 2 CR +1 V +1 07/18/15, 07:15
-
Georg Ringer commented on patch set 2 V -1 07/18/15, 07:57
save doesnt work anymore in any record -
Stefan Neufeind commented on patch set 2 CR -1 V -1 07/18/15, 09:09
I'll get rid of the margin. Having the padding:0px "hardcoded" in there is fine with Benni for the moment, since the docheaders will be redone anyway :-) The submits work, but the records aren't saved anymore. @Georg: I'll look into that now. -
Stefan Neufeind uploaded patch set 3 07/18/15, 09:23
-
Stefan Neufeind commented on patch set 3 07/18/15, 09:27
Saves etc. work not. Problem was that <input type="image" name="save"> actually without another "value" given submits the x and y-coordinates where you clicked. That's sent as $_POSTT['save_x'] (and _y). The code looks for save_x - so for the moment we'll just set the name correct to make it work again. We might later find a better term for "savedok_x" or so (why dok with k?) - but maybe we should do that when the docheader is reworked anyway. -
Anja Leichsenring commented on patch set 3 V -1 07/18/15, 09:31
tried with template setup - no save. This needs more work. -
Jan Helke uploaded patch set 4 07/21/15, 06:35
-
Andreas Kienast commented on patch set 4 07/21/15, 06:44
EditDocumentController.php:1121Do we need those? :) -
Jan Helke commented on patch set 4 07/21/15, 08:09
EditDocumentController.php:1121Reply:) No. Will remove them hopefully this evening. -
Christian Kuhn commented on patch set 4 V -1 07/21/15, 17:25
in general +1, but the images in edit document controller, page layout and typo script template module "look ugly" ;) the "save" button text overlays the save buttons. -
Stefan Neufeind commented on patch set 4 CR -1 07/22/15, 11:04
Hmm, do we really need to pass the buttons as the "html"-param to the spriteicon-function? The other solutions were to simply have opening/closing string for button directly around the spriteicon-call. Why didn't that work?!? (And afaik I saw that done in other places of the core). -
Wouter Wolters commented on patch set 4 CR -1 08/05/15, 11:15
TypoScriptTemplateModuleController.php:290button -
Wouter Wolters uploaded patch set 5 08/05/15, 11:15
-
Wouter Wolters voted on patch set 5 V +1 CR +1 08/05/15, 11:19
-
Sascha Wilking commented on patch set 5 CR +1 V -1 08/05/15, 12:39
The save buttons in page or content element edit mode in Google Chrome don't look good. In Firefox and IE the buttons are fine. -
Wouter Wolters uploaded patch set 6 08/05/15, 12:55
-
Wouter Wolters voted on patch set 6 V +1 CR +1 08/05/15, 12:55
-
Stefan Neufeind commented on patch set 6 V -1 CR +1 08/05/15, 13:11
testing -
Stefan Neufeind commented on patch set 6 V +1 CR 0 08/05/15, 13:15
Works. But using an input-type "image" without specifying one imho "feels so wrong" *sigh* Anyway, works. -
Sascha Wilking voted on patch set 6 V +1 CR +1 08/05/15, 13:20
-
Stefan Neufeind commented on patch set 6 08/05/15, 13:22
http://www.w3.org/TR/html5/forms.html#image-button-state-%28type=image%29 "The src attribute must be present, and must contain ..." etc. ... -
Frank Nägler commented on patch set 6 CR -1 08/05/15, 19:02
EditDocumentController.php:1120The src attribute is required for <input type="image">, and can only be used with <input type="image">. -
Anja Leichsenring voted on patch set 6 CR +2 V +2 08/05/15, 19:02
-
Anja Leichsenring merged patch set 6 08/05/15, 19:02
-
Stefan Neufeind commented on patch set 7 08/05/15, 19:22
What about the (imho valid) concerns that type="image" is not the right tool to use here? "But it works" is dangerous imho. I'm fine to have it as a first step to get rid of clear.gif, but would like to know if there is a followup planned (and if so, please file one!). -
Wouter Wolters commented on patch set 7 08/05/15, 19:52
Here it is https://review.typo3.org/#/c/42293/