Review main Merged

41613[TASK] Change first install message and color

Oliver Eglseder CR +2 V +2 Easy +11 −3 updated 07/17/15, 22:58

Commit message

Changes the background color of the FIRST_INSTALL page to green,
changes the icon from warning to success and replaces
the message to "Thank you [...]"

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 2

Review log 16

  1. Oliver Eglseder uploaded patch set 1 07/17/15, 21:04

  2. Marco Huber voted on patch set 1 CR +1 V +1 07/17/15, 21:23

  3. Ralf Merz voted on patch set 1 CR +1 V +1 07/17/15, 21:30

  4. Jozef Spisiak voted on patch set 1 CR +1 07/17/15, 21:32

  5. Hans Mayer commented on patch set 1 V +1 CR -1 07/17/15, 21:36

    EarlyExit.css:47

    please use uniform indentation
  6. Oliver Eglseder uploaded patch set 2 07/17/15, 21:42

  7. Markus Sommer uploaded patch set 3 07/17/15, 21:45

  8. Markus Sommer commented on patch set 3 CR +1 V +1 07/17/15, 21:46

    Looks good, max-width only for a littlebit responsive
  9. Jozef Spisiak voted on patch set 3 CR +1 07/17/15, 21:47

  10. Ralf Merz voted on patch set 3 CR +1 V +1 07/17/15, 21:55

  11. Hans Mayer voted on patch set 3 CR +1 V +1 07/17/15, 21:55

  12. Helmut Hummel voted on patch set 3 CR +2 V +2 07/17/15, 22:50

  13. Gerrit wrote 07/17/15, 22:50

    The change could not be merged due to a path conflict. Please rebase the change locally and upload the rebased commit for review.
  14. Helmut Hummel uploaded patch set 4 07/17/15, 22:51

  15. Andreas Wolf voted on patch set 4 CR +2 V +2 07/17/15, 22:58

  16. Andreas Wolf merged patch set 4 07/17/15, 22:58