Review main Merged

41615[TASK] Replace clear.gif img-tags with spans

Jan Helke CR +2 V +2 Easy +24 −24 updated 07/17/15, 23:30

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Patrick Kollodzik +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Patrick Kollodzik +1

Issues 2

Files 7

Review log 13

  1. Jan Helke uploaded patch set 1 07/17/15, 21:07

  2. Hans Mayer voted on patch set 1 V +1 07/17/15, 21:14

  3. Markus Sommer commented on patch set 1 CR -1 V -1 07/17/15, 21:23

    What about the clear.gif 's in "typo3/sysext/compatibility6/Classes/ContentObject/ColumnsContentObject.php" ? and many other files?
  4. Stefan Neufeind commented on patch set 1 07/17/15, 21:32

    I just talked to Andreas Wolf about the clear.gif in compatibility6. We tend to NOT change the clear.gif in compatibility6. The others of course can be adapted, if there are some missing.
  5. Jan Helke commented on patch set 1 07/17/15, 21:40

    I tend to keep the patches simple and easy to overlook.
  6. Stefan Neufeind commented on patch set 1 CR -2 07/17/15, 22:06

    We're working on the spans ...
  7. Patrick Kollodzik uploaded patch set 2 07/17/15, 23:09

  8. Stefan Neufeind voted on patch set 2 CR +1 V +1 07/17/15, 23:13

  9. Patrick Kollodzik commented on patch set 2 CR +1 V +1 07/17/15, 23:13

    We removed the two save buttons from the transition, because those need some more work and are not part of this ticket.
  10. Stefan Neufeind commented on patch set 2 07/17/15, 23:15

    ContentObjectRenderer.php:6892

    Could somebody please have a look into this? Should work and imho is "fine" as a replacement. border=0 we don't really need imho.

    TypoScriptTemplateModuleController.php:556

    hspace of 10px is 10px left + 10px right. Since we have just a width only, we can safely add that up imho.
  11. Benni Mack commented on patch set 2 07/17/15, 23:27

    ContentObjectRenderer.php:6892 Reply

    yes. that's fine.
  12. Benni Mack voted on patch set 2 CR +2 V +2 07/17/15, 23:29

  13. Benni Mack merged patch set 2 07/17/15, 23:30