Review main Merged

41626[TASK] Rename AccessNotAllowedAction to FirstInstallAction

Oliver Eglseder CR +2 V +2 Easy +3 −3 updated 07/17/15, 22:38

Commit message

AccessNotAllowed does IMHO not reflect the
intended message of the FIRST_INSTALL screen.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Ralf Merz +1
    • Markus Sommer +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Sommer +1

Issues 1

Files 3

Review log 7

  1. Oliver Eglseder uploaded patch set 1 07/17/15, 21:51

  2. Ralf Merz voted on patch set 1 CR +1 07/17/15, 22:06

  3. Markus Sommer voted on patch set 1 CR +1 V +1 07/17/15, 22:09

  4. Christian Kuhn commented on patch set 1 CR -1 07/17/15, 22:20

    on it.
  5. Oliver Eglseder commented on patch set 1 07/17/15, 22:38

    > on it. why negative vote?
  6. Christian Kuhn voted on patch set 1 CR +2 V +2 07/17/15, 22:38

  7. Christian Kuhn merged patch set 1 07/17/15, 22:38