Review main Abandoned

41636[TASK] Remove unused class

Markus Sommer CR 0 V 0 Easy +0 −0 updated 07/18/15, 12:56

Commit message

This Viewhelper is removed in #68139

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 0

No files imported.

Review log 11

  1. Markus Sommer uploaded patch set 1 07/17/15, 22:36

  2. Jan Helke commented on patch set 1 CR -1 07/17/15, 22:56

    LegacyClassesForIde.php:23

    Nope. With this patch you throw away the information, that the class was gone for good by intention. And developers who used this in the past must have the possibility to get this information.
  3. Jan Helke commented on patch set 1 CR 0 07/17/15, 23:02

    LegacyClassesForIde.php:23 Reply

    Done
  4. Anja Leichsenring commented on patch set 1 CR -1 07/18/15, 10:25

    this needs to stay, because otherwise compatibility6 is not working as advertised. The class is in use for version 6 and below.
  5. Benni Mack commented on patch set 1 07/18/15, 10:31

    but the class is removed...
  6. Benni Mack voted on patch set 1 CR +1 07/18/15, 10:31

  7. Wouter Wolters commented on patch set 1 V +1 CR +1 07/18/15, 12:42

    Class is deleted by me. It does not exists anymore in CMS 7
  8. Christian Kuhn voted on patch set 1 CR -1 07/18/15, 12:48

  9. Christian Kuhn commented on patch set 1 07/18/15, 12:54

    ... it seems both occurrences were removed yesterday already with https://review.typo3.org/#/c/41643/
  10. Wouter Wolters rebased onto patch set 1 07/18/15, 12:55

  11. Wouter Wolters abandoned the change 07/18/15, 12:56

    This is already done and merged. Rebase gives now an empty commit.