Review main Merged

41660[TASK] EXT:func Uniform extension directory structure

Michael Oehlhof CR +2 V +2 Easy +2 −2 updated 07/19/15, 14:01

Commit message

Moved the code from the mod1 directory to the Modules/AdvancedFunctions
directory.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Wouter Wolters +1
  • Verified V +2
    • Jigal van Hemert +2
    • Wouter Wolters +1

Issues 1

Files 3

Review log 11

  1. Michael Oehlhof uploaded patch set 1 07/18/15, 09:45

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 07/18/15, 10:15

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 07/18/15, 10:15

  4. Michael Oehlhof uploaded patch set 2 07/18/15, 10:19

  5. Michael Oehlhof commented on patch set 2 07/18/15, 10:22

    Had to update the patch. The relative path to the tab image was no longer correct because of the changed directory level of the index.php
  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 07/18/15, 10:26

  7. Wouter Wolters commented on patch set 2 CR -1 07/18/15, 10:28

    This works but we have another idea for the icon to be loaded. This needs a patch first. Will work on that now.
  8. Michael Oehlhof uploaded patch set 3 07/18/15, 14:26

  9. Wouter Wolters voted on patch set 3 V +1 CR +1 07/19/15, 13:59

  10. Jigal van Hemert voted on patch set 3 CR +2 V +2 07/19/15, 14:01

  11. Jigal van Hemert merged patch set 3 07/19/15, 14:01