Review main Merged

41663[BUGFIX] includeCSS is not compressed and concatenated

Sebastian Michaelsen CR +2 V +2 Easy +11 −8 updated 07/22/15, 19:04

Commit message

The CSS files defined in page.includeCSSLibs don't get concatenated and
compressed if you enable config.compressCss and config.concatenateCss

Review

  • Code review CR +2
    • Susi Moog +2
    • Alexander Stehlik +1
    • Thomas Löffler +1
  • Verified V +2
    • Susi Moog +2
    • Alexander Stehlik +1

Issues 1

Files 1

Review log 18

  1. Sebastian Michaelsen uploaded patch set 1 07/18/15, 11:14

  2. Sebastian Michaelsen uploaded patch set 2 07/18/15, 11:19

  3. Markus Sommer updated the commit message in patch set 3 07/18/15, 11:21

  4. Sebastian Michaelsen updated the commit message in patch set 4 07/18/15, 11:28

  5. Alexander Stehlik voted on patch set 4 CR +1 07/18/15, 11:38

  6. Alexander Stehlik commented on patch set 4 V -1 07/18/15, 11:49

    Problems when concat / compress is enabled: 1. The same compressed CSS file is included twice. 2. The CSS form includeCSSlibs is not included at all
  7. Sebastian Michaelsen uploaded patch set 5 07/18/15, 12:32

  8. Alexander Stehlik voted on patch set 5 CR +1 V +1 07/19/15, 06:55

  9. Harry Glatz voted on patch set 5 V +1 07/19/15, 07:11

  10. Sebastian Michaelsen updated the commit message in patch set 6 07/19/15, 08:28

  11. Thomas Löffler voted on patch set 6 CR +1 07/19/15, 08:30

  12. Alexander Stehlik voted on patch set 6 CR +1 V +1 07/19/15, 08:36

  13. Susi Moog voted on patch set 6 CR +2 V +2 07/20/15, 17:46

  14. Susi Moog merged patch set 6 07/20/15, 17:47

  15. Susi Moog commented on patch set 7 07/20/15, 17:48

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 9918fc0d68f4f2267df38cabc9f011b3da1f3db1
  16. Helmut Hummel commented on patch set 7 07/22/15, 18:02

    post -1 verified This change breaks my page tree in the backend
  17. Markus Klein commented on patch set 7 07/22/15, 18:17

    You have to test this with BE|debug = 0
  18. Markus Klein commented on patch set 7 07/22/15, 19:04

    this patch does not seem to be the issue. There is some more problems with backPaths in the compressor.